Skip to content

Commit

Permalink
Change log for March 17, 2023 Vulkan 1.3.244 spec update:
Browse files Browse the repository at this point in the history
Github Issues:

  * Fix typo in
    slink:VkDeviceGroupRenderPassBeginInfo::pname:deviceRenderAreaCount
    (public issue 2078).

Internal Issues

  * Move copy attribute's pname: to commonvalidity attributes to aid with
    VUID generation (internal MR 5781).
  * Add a .mailmap file (internal MR 5786).
  * Refactor pipeline layout consistency VUs for
    slink:VkComputePipelineCreateInfo, slink:VkGraphicsPipelineCreateInfo,
    and slink:VkRayTracingPipelineCreateInfoNV into common validity
    statements (internal MR 5750).
  * Make VUID tag generation prioritize attributes, helping ensure tags are
    unique when the same common validity file is included twice in the same
    VU block (internal MR 5791).

New Extensions:

  * apiext:VK_KHR_map_memory2
  • Loading branch information
oddhack committed Mar 18, 2023
1 parent 84ccde6 commit 7beccb6
Show file tree
Hide file tree
Showing 35 changed files with 902 additions and 198 deletions.
6 changes: 6 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Copyright 2023 The Khronos Group Inc.
# SPDX-License-Identifier: CC-BY-4.0

Faith Ekstrand <faith.ekstrand@collabora.com> <jason@jlekstrand.net>
Faith Ekstrand <faith.ekstrand@collabora.com> <jason.ekstrand@intel.com>
Faith Ekstrand <faith.ekstrand@collabora.com> <jason.ekstrand@collabora.com>
27 changes: 27 additions & 0 deletions ChangeLog.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,33 @@ appears frequently in the change log.

-----------------------------------------------------

Change log for March 17, 2023 Vulkan 1.3.244 spec update:

Github Issues:

* Fix typo in
slink:VkDeviceGroupRenderPassBeginInfo::pname:deviceRenderAreaCount
(public issue 2078).

Internal Issues

* Move copy attribute's pname: to commonvalidity attributes to aid with
VUID generation (internal MR 5781).
* Add a .mailmap file (internal MR 5786).
* Refactor pipeline layout consistency VUs for
slink:VkComputePipelineCreateInfo, slink:VkGraphicsPipelineCreateInfo,
and slink:VkRayTracingPipelineCreateInfoNV into common validity
statements (internal MR 5750).
* Make VUID tag generation prioritize attributes, helping ensure tags are
unique when the same common validity file is included twice in the same
VU block (internal MR 5791).

New Extensions:

* apiext:VK_KHR_map_memory2

-----------------------------------------------------

Change log for March 12, 2023 Vulkan 1.3.243 spec update:

Github Issues:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ VERBOSE =
# ADOCOPTS options for asciidoc->HTML5 output

NOTEOPTS = -a editing-notes -a implementation-guide
PATCHVERSION = 243
PATCHVERSION = 244

ifneq (,$(findstring VK_VERSION_1_3,$(VERSIONS)))
SPECMINOR = 3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ include::{generated}/meta/{refprefix}VK_ANDROID_external_memory_android_hardware
No known IP claims.
*Contributors*::
- Ray Smith, ARM
- Chad Versace, Google
- Lina Versace, Google
- Jesse Hall, Google
- Tobias Hector, Imagination
- James Jones, NVIDIA
Expand Down
2 changes: 1 addition & 1 deletion appendices/VK_EXT_extended_dynamic_state.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ is that this state should be more or less free to change.

ifdef::VK_EXT_vertex_input_dynamic_state[]
apiext:VK_EXT_vertex_input_dynamic_state allows the stride to be changed
freely when supported via flink:vkCmdSetVertexInputStateEXT[].
freely when supported via flink:vkCmdSetVertexInputEXT[].
endif::VK_EXT_vertex_input_dynamic_state[]


Expand Down
4 changes: 2 additions & 2 deletions appendices/VK_EXT_external_memory_dma_buf.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ include::{generated}/meta/{refprefix}VK_EXT_external_memory_dma_buf.adoc[]
*IP Status*::
No known IP claims.
*Contributors*::
- Chad Versace, Google
- Lina Versace, Google
- James Jones, NVIDIA
- Faith Ekstrand, Intel

Expand Down Expand Up @@ -55,5 +55,5 @@ to code:dma_buf.

=== Version History

* Revision 1, 2017-10-10 (Chad Versace)
* Revision 1, 2017-10-10 (Lina Versace)
** Squashed internal revisions
4 changes: 2 additions & 2 deletions appendices/VK_EXT_image_drm_format_modifier.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include::{generated}/meta/{refprefix}VK_EXT_image_drm_format_modifier.adoc[]
*Contributors*::
- Antoine Labour, Google
- Bas Nieuwenhuizen, Google
- Chad Versace, Google
- Lina Versace, Google
- James Jones, NVIDIA
- Faith Ekstrand, Intel
- Jőrg Wagner, ARM
Expand Down Expand Up @@ -405,7 +405,7 @@ _requires_ the application to set pname:size to 0.

==== Version History

* Revision 1, 2018-08-29 (Chad Versace)
* Revision 1, 2018-08-29 (Lina Versace)
** First stable revision
* Revision 2, 2021-09-30 (Jon Leech)
** Add interaction with `apiext:VK_KHR_format_feature_flags2` to `vk.xml`
4 changes: 2 additions & 2 deletions appendices/VK_EXT_queue_family_foreign.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ include::{generated}/meta/{refprefix}VK_EXT_queue_family_foreign.adoc[]
*IP Status*::
No known IP claims.
*Contributors*::
- Chad Versace, Google
- Lina Versace, Google
- James Jones, NVIDIA
- Faith Ekstrand, Intel
- Jesse Hall, Google
Expand Down Expand Up @@ -44,5 +44,5 @@ include::{generated}/interfaces/VK_EXT_queue_family_foreign.adoc[]

=== Version History

* Revision 1, 2017-11-01 (Chad Versace)
* Revision 1, 2017-11-01 (Lina Versace)
** Squashed internal revisions
2 changes: 1 addition & 1 deletion appendices/VK_EXT_swapchain_maintenance1.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ include::{generated}/meta/{refprefix}VK_EXT_swapchain_maintenance1.adoc[]
- Ian Elliott, Google
- Yiwei Zhang, Google
- Charlie Lao, Google
- Chad Versace, Google
- Lina Versace, Google
- Ralph Potter, Samsung
- Igor Nazarov, Samsung
- Hyunchang Kim, Samsung
Expand Down
2 changes: 1 addition & 1 deletion appendices/VK_HUAWEI_cluster_culling_shader.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ void main()
// cluster based culling
bool render = (!isSphereOutsideFrustum(desc.sphere.center,
desc.sphere.radius) && isFrontFaceVisible(desc.sphere.center, desc.sphere.radius, desc.cone.norm
al, desc.cone.angle));
al, desc.cone.angle));
if (render)
{
Expand Down
2 changes: 1 addition & 1 deletion appendices/VK_KHR_external_memory.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ include::{generated}/meta/{refprefix}VK_KHR_external_memory.adoc[]
- Daniel Rakos, AMD
- Carsten Rohde, NVIDIA
- Ray Smith, ARM
- Chad Versace, Google
- Lina Versace, Google

=== Description

Expand Down
2 changes: 1 addition & 1 deletion appendices/VK_KHR_external_semaphore.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ include::{generated}/meta/{refprefix}VK_KHR_external_semaphore.adoc[]
- Jeff Juliano, NVIDIA
- Matthew Netsch, Qualcomm Technologies, Inc.
- Ray Smith, ARM
- Chad Versace, Google
- Lina Versace, Google

=== Description

Expand Down
32 changes: 32 additions & 0 deletions appendices/VK_KHR_map_memory2.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Copyright 2023 The Khronos Group Inc.
//
// SPDX-License-Identifier: CC-BY-4.0

include::{generated}/meta/{refprefix}VK_KHR_map_memory2.adoc[]

=== Other Extension Metadata

*Last Modified Date*::
2023-03-14
*Interactions and External Dependencies*::
- None
*Contributors*::
- Faith Ekstrand, Collabora
- Tobias Hector, AMD

=== Description

This extension provides extensible versions of the Vulkan memory map and
unmap entrypoints.
The new entrypoints are functionally identical to the core entrypoints,
except that their parameters are specified using extensible structures that
can be used to pass extension-specific information.

include::{generated}/interfaces/VK_KHR_map_memory2.adoc[]

=== Version History

* Revision 0, 2022-08-03 (Faith Ekstrand)
** Internal revisions
* Revision 1, 2022-03-14

This comment has been minimized.

Copy link
@tambry

tambry Mar 18, 2023

Should be 2023-03-14?

This comment has been minimized.

Copy link
@oddhack

oddhack Mar 19, 2023

Author Contributor

Yes, thanks. Will be fixed in the next spec update.

** Public release
2 changes: 1 addition & 1 deletion appendices/credits.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ their name.
* Caio Marcelo de Oliveira Filho, Intel (versions 1.2, 1.3)
* Cass Everitt, Oculus VR (versions 1.0, 1.1)
* Cemil Azizoglu, Canonical (version 1.0)
* Chad Versace, Google (versions 1.0, 1.1, 1.2)
* Lina Versace, Google (versions 1.0, 1.1, 1.2)
* Chang-Hyo Yu, Samsung Electronics (version 1.0)
* Charles Giessen, LunarG (version 1.3)
* Chia-I Wu, LunarG (version 1.0)
Expand Down
34 changes: 17 additions & 17 deletions chapters/commonvalidity/copy_anyimage_to_imageany_common.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,28 @@
// field in pRegions corresponding to {imageparam}

ifndef::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-None-07922]]
If {imageparam} is non-sparse then it must: be bound completely and
contiguously to a single sname:VkDeviceMemory object
* [[VUID-{refpage}-{imageparam}-07965]]
If pname:{imageparam} is non-sparse then it must: be bound completely
and contiguously to a single sname:VkDeviceMemory object
endif::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
ifdef::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-None-07923]]
If {imageparam} is non-sparse then the image or the specified _disjoint_
plane must: be bound completely and contiguously to a single
* [[VUID-{refpage}-{imageparam}-07966]]
If pname:{imageparam} is non-sparse then the image or the specified
_disjoint_ plane must: be bound completely and contiguously to a single
sname:VkDeviceMemory object
endif::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-pRegions-07924]]
The {imagesubresource}.mipLevel member of each element of pname:pRegions
must: be less than the pname:mipLevels specified in
slink:VkImageCreateInfo when {imageparam} was created
* [[VUID-{refpage}-imageSubresource-07925]]
The [eq]#{imagesubresource}.baseArrayLayer {plus}
pname:imageSubresource.layerCount# of each element of pname:pRegions
* [[VUID-{refpage}-{imagesubresource}-07967]]
The pname:{imagesubresource}.mipLevel member of each element of
pname:pRegions must: be less than the pname:mipLevels specified in
slink:VkImageCreateInfo when pname:{imageparam} was created
* [[VUID-{refpage}-{imagesubresource}-07968]]
The [eq]#pname:{imagesubresource}.baseArrayLayer {plus}
pname:{imageSubresource}.layerCount# of each element of pname:pRegions
must: be less than or equal to the pname:arrayLayers specified in
slink:VkImageCreateInfo when {imageparam} was created
slink:VkImageCreateInfo when pname:{imageparam} was created
ifdef::VK_EXT_fragment_density_map[]
* [[VUID-{refpage}-flags-07926]]
{imageparam} must: not have been created with pname:flags containing
ename:VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT
* [[VUID-{refpage}-{imageparam}-07969]]
pname:{imageparam} must: not have been created with pname:flags
containing ename:VK_IMAGE_CREATE_SUBSAMPLED_BIT_EXT
endif::VK_EXT_fragment_density_map[]
// Common Valid Usage
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@
// Additionally, it relies on the {imagesubresource} attribute to specify the
// field in pRegions corresponding to {imageparam}

* [[VUID-{refpage}-pRegions-07927]]
* [[VUID-{refpage}-{imagesubresource}-07970]]
The image region specified by each element of pname:pRegions must: be
contained within the specified {imagesubresource} of {imageparam}
* [[VUID-{refpage}-pRegions-07928]]
contained within the specified pname:{imagesubresource} of
pname:{imageparam}
* [[VUID-{refpage}-{imagesubresource}-07971]]
For each element of pname:pRegions, pname:imageOffset.x and
[eq]#(pname:imageExtent.width {plus} pname:imageOffset.x)# must: both be
greater than or equal to `0` and less than or equal to the width of the
specified {imagesubresource} of {imageparam}
* [[VUID-{refpage}-pRegions-07929]]
specified pname:{imagesubresource} of pname:{imageparam}
* [[VUID-{refpage}-{imagesubresource}-07972]]
For each element of pname:pRegions, pname:imageOffset.y and
[eq]#(pname:imageExtent.height {plus} pname:imageOffset.y)# must: both
be greater than or equal to `0` and less than or equal to the height of
the specified {imagesubresource} of {imageparam}
the specified pname:{imagesubresource} of pname:{imageparam}
// Common Valid Usage
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// which includes this file, specifying the name of the source or
// destination image.

* [[VUID-{refpage}-None-07930]]
{imageparam} must: have a sample count equal to
* [[VUID-{refpage}-{imageparam}-07973]]
pname:{imageparam} must: have a sample count equal to
ename:VK_SAMPLE_COUNT_1_BIT
// Common Valid Usage
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,30 @@
// - {imageparam}, specifying the name of the source or destination image,

ifndef::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-bufferOffset-00193]]
If {imageparam} does not have a depth/stencil format, then for each
element of pname:pRegions, pname:bufferOffset must: be a multiple of the
format's texel block size
* [[VUID-{refpage}-{imageparam}-07974]]
If pname:{imageparam} does not have a depth/stencil format, then for
each element of pname:pRegions, pname:bufferOffset must: be a multiple
of the format's texel block size
endif::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
ifdef::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-bufferOffset-01558]]
If {imageparam} does not have either a depth/stencil or a
* [[VUID-{refpage}-{imageparam}-07975]]
If pname:{imageparam} does not have either a depth/stencil or a
<<formats-requiring-sampler-ycbcr-conversion,multi-planar format>>, then
for each element of pname:pRegions, pname:bufferOffset must: be a
multiple of the format's texel block size
* [[VUID-{refpage}-bufferOffset-01559]]
If {imageparam} has a
* [[VUID-{refpage}-{imageparam}-07976]]
If pname:{imageparam} has a
<<formats-requiring-sampler-ycbcr-conversion,multi-planar format>>, then
for each element of pname:pRegions, pname:bufferOffset must: be a
multiple of the element size of the compatible format for the format and
the pname:aspectMask of the pname:imageSubresource as defined in
<<formats-compatible-planes>>
endif::VK_VERSION_1_1,VK_KHR_sampler_ycbcr_conversion[]
* [[VUID-{refpage}-pRegions-07273]]
* [[VUID-{refpage}-{imageparam}-07977]]
For each element of pname:pRegions, pname:bufferOffset must: be a
multiple of the <<formats-compatibility-classes,texel block size>> of
the elink:VkFormat of {imageparam}
* [[VUID-{refpage}-srcImage-04053]]
If {imageparam} has a depth/stencil format, the pname:bufferOffset
the elink:VkFormat of pname:{imageparam}
* [[VUID-{refpage}-{imageparam}-07978]]
If pname:{imageparam} has a depth/stencil format, the pname:bufferOffset
member of any element of pname:pRegions must: be a multiple of `4`
// Common Valid Usage
Loading

0 comments on commit 7beccb6

Please sign in to comment.