Add XML consistency checks including pNext 'optional' #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accompanies #1592. The xml_consistency.py script checks for a variety of other problems in vk.xml, but hasn't been run in CI until now. The MR also makes a few tweaks to fix or ignore two unrelated issues found by the script.
The current version of the reuse tool complains about unused licenses and this is causing the updated CI image to fail the 'reuse lint' check.
This is a replacement for #1592 since that appeared to have some git artifacts resulting from a rebase that are breaking CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1592.
The xml_consistency.py script checks for a variety of problems in
vk.xml, but hasn't been run in CI until now. The MR also makes a few
tweaks to fix or ignore two unrelated issues found by the script.
Edit: Interestingly, there is at least one API where pNext is not optional: VkVideoEncodeInfoKHR::pNext says that "a codec-specific extension structure must: be chained". That is treated as an exception in the CI script and is not tagged 'optional="true"'.