Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: move _POSIX_C_SOURCE where pthread_condattr_setclock is used #207

Merged
merged 1 commit into from Apr 26, 2023
Merged

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Apr 26, 2023

Fixes #206

@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023

CLA assistant check
All committers have signed the CLA.

@jbeich
Copy link
Contributor Author

jbeich commented Apr 26, 2023

I've already signed CLA in KhronosGroup/Vulkan-Loader#419 and KhronosGroup/Vulkan-ValidationLayers#5098. CLA assistant is still listed in https://github.com/settings/applications (Authorized OAuth Apps tab).

@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 5245.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 410 running.

Copy link
Collaborator

@jeremyg-lunarg jeremyg-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 410 passed.

@jeremyg-lunarg
Copy link
Collaborator

@jbeich Your fix is ready to go but you must sign the CLA before I can merge it.

@juan-lunarg
Copy link
Contributor

I've already signed CLA in KhronosGroup/Vulkan-Loader#419 and KhronosGroup/Vulkan-ValidationLayers#5098. CLA assistant is still listed in https://github.com/settings/applications (Authorized OAuth Apps tab).

The CLA doesn't apply to the organization. It's configured per repo. Not sure why.

@jbeich
Copy link
Contributor Author

jbeich commented Apr 26, 2023

https://cla-assistant.io/check/KhronosGroup/Vulkan-ExtensionLayer?pullRequest=207 redirects me to https://github.com/ (main page). Am I supposed to revoke @CLAassistant from authorized OAuth apps just to trigger CLA?

@juan-lunarg
Copy link
Contributor

https://cla-assistant.io/check/KhronosGroup/Vulkan-ExtensionLayer?pullRequest=207 redirects me to https://github.com/ (main page). Am I supposed to revoke @CLAassistant from authorized OAuth apps just to trigger CLA?

This link looks fine. The check variant redirects.
https://cla-assistant.io/KhronosGroup/Vulkan-ExtensionLayer?pullRequest=207

@jbeich
Copy link
Contributor Author

jbeich commented Apr 26, 2023

Thanks for the pointer. I've signed the CLA.

@juan-lunarg juan-lunarg merged commit 580f183 into KhronosGroup:main Apr 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.3.248 fails to build with libc++
5 participants