Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: restore X11/Wayland support on non-Linux #5098

Merged
merged 1 commit into from
Jan 12, 2023
Merged

cmake: restore X11/Wayland support on non-Linux #5098

merged 1 commit into from
Jan 12, 2023

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Jan 12, 2023

Regressed by #4954. Disable platform gatekeeping as X11/Wayland are also supported on BSDs. CC @brad0

$ vkcube-wayland --validate
WARNING : VALIDATION - Message Id Number: 2044605652 | Message Id Name: VUID_Undefined
        Validation Warning: [ VUID_Undefined ] Object 0: handle = 0x82876a000, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x79de34d4 | Instance Extension VK_KHR_wayland_surface is not supported by this layer.  Using this extension may adversely affect validation results and/or produce undefined behavior.

        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 0x82876a000

Selected GPU 0: Intel(R) HD Graphics 530 (SKL GT2), type: IntegratedGpu
ERROR : VALIDATION - Message Id Number: -2145442690 | Message Id Name: VUID-vkGetPhysicalDeviceSurfaceSupportKHR-surface-parameter
        Validation Error: [ VUID-vkGetPhysicalDeviceSurfaceSupportKHR-surface-parameter ] Object 0: handle = 0x82876a000, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x801f247e | Invalid VkSurfaceKHR Object 0x828746c30. The Vulkan spec states: surface must be a valid VkSurfaceKHR handle (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkGetPhysicalDeviceSurfaceSupportKHR-surface-parameter)

        Objects - 1
                Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 0x82876a000

ERROR : VALIDATION - Message Id Number: 1567320034 | Message Id Name: UNASSIGNED-Threading-Info
        Validation Error: [ UNASSIGNED-Threading-Info ] Object 0: handle = 0x828746c30, type = VK_OBJECT_TYPE_SURFACE_KHR; | MessageID = 0x5d6b67e2 | Couldn't find VkSurfaceKHR Object 0x828746c30. This should not happen and may indicate a bug in the application.

        Objects - 1
                Object[0] - VK_OBJECT_TYPE_SURFACE_KHR, Handle 0x828746c30

Segmentation fault

@jbeich jbeich requested a review from a team as a code owner January 12, 2023 16:11
@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 1638.

Copy link
Contributor

@juan-lunarg juan-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend your commit message and force push so it passes CI:

Checking commit: "f4d438f73 cmake: restore X11/Wayland support on non-Linux after 33935a1619dc"

The following subject line exceeds 64 characters in length.
     'cmake: restore X11/Wayland support on non-Linux after 33935a1619dc'

The first word of the subject line after the ':' character must be capitalized.
     'cmake: restore X11/Wayland support on non-Linux after 33935a1619dc'

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10198 running.

@ci-tester-lunarg
Copy link
Collaborator

Author jbeich not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 1688.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10200 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 10200 passed.

@juan-lunarg juan-lunarg merged commit 9f2c292 into KhronosGroup:master Jan 12, 2023
@brad0
Copy link
Contributor

brad0 commented Jan 12, 2023

@jbeich Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants