Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export symbols in vk::detail namespace #1931

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

sharadhr
Copy link
Contributor

Resolves #1928.

@asuessenbach asuessenbach merged commit 003cf8e into KhronosGroup:main Aug 5, 2024
14 checks passed
@asuessenbach
Copy link
Contributor

@sharadhr This PR just removed the symbols from the vk::detail namespace.
Would it be possible to export them in the vk::detail namespace, instead?

@sharadhr
Copy link
Contributor Author

sharadhr commented Aug 7, 2024

I'm sure that's possible, but do we really want to expose the detail stuff? I was under the impression the point of detail was to tell users that those symbols are not meant to be part of the public user-facing API, and not exporting them in the C++ module makes this very explicit.

@asuessenbach
Copy link
Contributor

You're kind of right, that stuff is part of the detail namespace and thus not part of the "official" vulkan.
But it seems, at least some guys want to use at least some of those functions. And as they are in the detail-namespace they (should) know, that they could be changed without further notice.
That is, you can use them now (on your own risk) when you don't use modules, but you can't use them with modules. Which might be worth to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[c++20 module] functions from vk::detail:: pulled into vk::
2 participants