Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Use main instead of master #344

Merged
merged 1 commit into from
Jan 17, 2023
Merged

github: Use main instead of master #344

merged 1 commit into from
Jan 17, 2023

Conversation

juan-lunarg
Copy link
Contributor

closes #338

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 3803.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 3815.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2252 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 3824.

juan-lunarg
juan-lunarg commented Jan 16, 2023
View reviewed changes
BUILD.md Show resolved Hide resolved
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2253 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2253 aborted.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 3887.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2254 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2254 aborted.

@christophe-lunarg
Copy link
Collaborator

The test that fails is extremely odd:

17: [ RUN      ] test_validate.VP_ANDROID_baseline_2022
17: VpProfile_test_schema_validation: /home/lunarg/.jenkins/workspace/VulkanProfiles/64-bit/Debug/VulkanProfiles/profiles/test/test_validate.cpp:64: Json::Value ParseJsonFile(const char*): Assertion `file.is_open()' failed.
17/17 Test #17: VpProfile_test_schema_validation ................................Subprocess aborted***Exception:   0.51 sec
Running main() from /home/lunarg/.jenkins/workspace/VulkanProfiles/64-bit/Debug/VulkanProfiles/dbuild/_deps/googletest-src/googletest/src/gtest_main.cc

The Android baselise 2022 profile is indeed new but I don't see why the test would sometime fail to open the file...
Investigating...

@juan-lunarg juan-lunarg merged commit 24c2424 into KhronosGroup:main Jan 17, 2023
@juan-lunarg juan-lunarg deleted the juaramos/master_to_main branch January 17, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-lunarg christophe-lunarg christophe-lunarg approved these changes

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please rename default branch from 'master' to 'main' per Khronos policy (update 2023-01-16)
4 participants
@juan-lunarg @ci-tester-lunarg @christophe-lunarg @ziga-lunarg