-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Pipelines #487
Event Pipelines #487
Conversation
Technically this looks great, but I'm not sure if we want to use the term pipeline for this. I fear that people could get confused with having graphics pipelines and also pipelines for event related stuff? |
@SaschaWillems |
05142f7
to
7ac00de
Compare
Rebased on events_bus |
Yes, I'm fine with |
Try |
Tried running that, but it just tells me that no tests were found. Even when building with |
In the CI we use:
This also works locally for me |
7ac00de
to
c3158df
Compare
Rebased @SaschaWillems @asuessenbach is this ready to be approved? |
Comments resolved, merging for now. The concept will evolve over time and more than likely be replaced in the near future if it does not fit its desired use case. |
* event bus * response to feedback * add assert * assert * added observer expiration test * add pipelines * stages with custom fields * Pipeline -> EventPipeline * add comments
Description
Builds on-top of #485.
The Event Bus allows for communication between components and the firing of one off events. It does not allow for a Sample to continually fire and react to a given sequence of events.
Pipelines aim to allow stages to continually run without the need for an Event Observer to submit the event manually. This allows a sample to have a very compact view of its execution flow. Samples can now have completely different execution flows.
Example