Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vkCmdDrawIndexedIndirect doesn't issue an error when the buffer wasn't created with VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT #450

Closed
zeux opened this issue Nov 4, 2018 · 1 comment · Fixed by #859
Closed

vkCmdDrawIndexedIndirect doesn't issue an error when the buffer wasn't created with VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT #450

zeux opened this issue Nov 4, 2018 · 1 comment · Fixed by #859
Assignees
@mark-lunarg
Labels
Incomplete Missing Validation VUs to be added
Milestone
sdk-1.1.108.0

Comments

@zeux
Copy link

zeux commented Nov 4, 2018 •
edited

Using a buffer with the following usage flags:

VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT

Should trigger an error in vkCmdDrawIndexedIndirect corresponding to the following VU:

buffer must have been created with the VK_BUFFER_USAGE_INDIRECT_BUFFER_BIT bit set

But it doesn't happen. Not sure if other VUs in this function are missed, sounds like this needs more validation coverage.
@zeux zeux mentioned this issue Nov 4, 2018
Closed
@mark-lunarg mark-lunarg self-assigned this Nov 4, 2018
@mark-lunarg mark-lunarg added the Incomplete Missing Validation VUs to be added label Nov 4, 2018
@zeux
Copy link
Author

zeux commented Nov 9, 2018

Note: vkCmdDrawMeshTasksIndirectNV is also missing the check for this VU

JasperNV added a commit to JasperNV/Vulkan-ValidationLayers that referenced this issue Apr 11, 2019
@JasperNV
layers: Check for indirect buffer usage
c1d03c1 
Fixes KhronosGroup#450.
@JasperNV JasperNV mentioned this issue Apr 11, 2019
Merged
JasperNV added a commit to JasperNV/Vulkan-ValidationLayers that referenced this issue Apr 11, 2019
@JasperNV
layers: Check for indirect buffer usage
3facc86 
Fixes KhronosGroup#450.
JasperNV added a commit to JasperNV/Vulkan-ValidationLayers that referenced this issue Apr 11, 2019
@JasperNV
layers: Check for indirect buffer usage
108895c 
Fixes KhronosGroup#450.
JasperNV added a commit to JasperNV/Vulkan-ValidationLayers that referenced this issue Apr 15, 2019
@JasperNV
layers: Check for indirect buffer usage
bac323a 
Fixes KhronosGroup#450.
tobine pushed a commit that referenced this issue Apr 16, 2019
@JasperNV @tobine
layers: Check for indirect buffer usage
bf08046 
Fixes #450.
@shannon-lunarg shannon-lunarg added this to the sdk-1.1.temp.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-lunarg mark-lunarg

Labels
Incomplete Missing Validation VUs to be added
Projects
None yet
Milestone
sdk-1.1.108.0
Development

Successfully merging a pull request may close this issue.

layers: Check indirect buffer usage JasperNV/Vulkan-ValidationLayers
3 participants
@zeux @mark-lunarg @shannon-lunarg