layers: Use concurrent_ordered_map for state objects #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 9149. |
|
CI Vulkan-ValidationLayers build # 5810 running. |
|
CI Vulkan-ValidationLayers build # 5810 failed. |
Use the thread safe unordered_map for all state objects. This makes it safe to call Add<>(), Get<>() or Remove<>() without holding a lock. Note that because Get<>() returns a shared_ptr to the state object, it will not be deleted while the caller holds this reference. This does make iterating all state objects even more expensive, but that was already a bad thing to do anyways.
jeremyg-lunarg
force-pushed
the
jeremyg-concurrent-objmap
branch
from
d6e7043
to
39d78e8
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 9270. |
|
CI Vulkan-ValidationLayers build # 5812 running. |
|
CI Vulkan-ValidationLayers build # 5812 passed. |
jeremyg-lunarg
requested review from
ncesario-lunarg,
TonyBarbour,
mark-lunarg and
ziga-lunarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the thread safe unordered_map for all state objects. This makes
it safe to call Add<>(), Get<>() or Remove<>() without holding a
lock. Note that because Get<>() returns a shared_ptr to the state
object, it will not be deleted while the caller holds this reference.
This does make iterating all state objects even more expensive, but
that was already a bad thing to do anyways.