Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webgl 1.0.3] conformance/more/conformance/quickCheckAPI-A.html fail when MAX_TEXTURE_IMAGE_UNITS >32 #3654

Closed
WujianSun opened this issue May 11, 2024 · 0 comments · Fixed by #3655 or #3659
Closed

[webgl 1.0.3] conformance/more/conformance/quickCheckAPI-A.html fail when MAX_TEXTURE_IMAGE_UNITS >32 #3654

WujianSun opened this issue May 11, 2024 · 0 comments · Fixed by #3655 or #3659

Comments

@WujianSun
Copy link
Contributor

My GPU is Mali G310 and MAX_TEXTURE_IMAGE_UNITS is 64, then the conformance/more/conformance/quickCheckAPI-A.html case will test fail.

I found GL['TEXTURE'+i] will be a undefined value when the index >=32.
https://github.com/KhronosGroup/WebGL/blob/main/conformance-suites/1.0.1/conformance/more/conformance/quickCheckAPI.js#L217

If webgl cts test had the limitation that can't cover MAX_TEXTURE_IMAGE_UNITS >32 GPU?
WujianSun added a commit to WujianSun/WebGL that referenced this issue May 13, 2024
@WujianSun
Fix quickCheckAPI-A fail when MAX_TEXTURE_IMAGE_UNITS > 32.(KhronosGr…
ba75945 
…oup#3654)

GL['TEXTURE'+i] will report not defined when MAX_TEXTURE_IMAGE_UNITS > 32.

Add more TEXTURE_IMAGE_UNITS support for modern GPU that may support 64
or more.

Fixes KhronosGroup#3654 .

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
@WujianSun WujianSun mentioned this issue May 13, 2024
Merged
kenrussell pushed a commit that referenced this issue May 31, 2024
@WujianSun
Fix quickCheckAPI-A fail when MAX_TEXTURE_IMAGE_UNITS > 32.(#3654) (#…
9d04f50 
…3655)

GL['TEXTURE'+i] will report not defined when MAX_TEXTURE_IMAGE_UNITS > 32.

Add more TEXTURE_IMAGE_UNITS support for modern GPU that may support 64
or more.

Fixes #3654 .

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
WujianSun added a commit to WujianSun/WebGL that referenced this issue May 31, 2024
@WujianSun
Backport changes to fix quickCheckAPI-A fail
edde5e8 
Pick the fixs(KhronosGroup#3655) for 2.0.0 and 1.0.3.

Fixes KhronosGroup#3654.

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
@WujianSun WujianSun mentioned this issue May 31, 2024
Merged
WujianSun added a commit to WujianSun/WebGL that referenced this issue May 31, 2024
@WujianSun
Backport changes to fix quickCheckAPI-A fail (KhronosGroup#3659)
522d1ed 
Pick the fixs(KhronosGroup#3655) for 2.0.0 and 1.0.3.

Fixes KhronosGroup#3654.

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
kenrussell pushed a commit that referenced this issue May 31, 2024
@WujianSun
Backport changes to fix quickCheckAPI-A fail (#3659) (#3659)
22e4642 
Pick the fixs(#3655) for 2.0.0 and 1.0.3.

Fixes #3654.

Signed-off-by: Wujian Sun <wujian.sun_1@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@WujianSun