Update tests for recent ECMAScript changes #1947
Conversation
|
Thanks, this looks good. Could you please:
Thanks. CC'ing @jdashg @RafaelCintron @grorg @zhenyao . The old behavior should be removed in the top-of-tree conformance suite, once all browsers implement the new behavior. I'll file a follow-on bug about this once it lands. |
| @@ -641,21 +641,27 @@ | |||
| var array; | |||
| try { | |||
| array = new type(null); | |||
| testFailed("Construction of " + name + " with null buffer should throw exception"); | |||
| assertEq("Length of " + name + " constructed with null", 0, array.length); | |||
| testPassed("Construction of " + name + " with null produced a " + name + "of length 0"); | |||
There was a problem hiding this comment.
missing a space at the beginning of the last literal in this line
bakkot
force-pushed
the
ecmascript-changes
branch
from
de58bd2
to
fc7fac0
Compare
|
Done. Both Chrome and Firefox pass on 1.0.1, 1.0.2, and 1.0.3, and Chrome continues to pass (which it did not previously) when updated to use the now-current semantics. I can't easily test other browsers, but I could do so if necessary. |
|
Thank you very much for updating the older snapshots (so they'll continue to pass on older browsers) and for testing with multiple browsers. The testing you did is great. LGTM. Merging now. |
Several tests are making outdated assertions about various TypedArray and DataView related functions. Their behavior was changed by TC39 recently.
This PR amends those tests so that either the old or new behavior is accepted. I'm not sure if there's a way to officially mark one behavior as deprecated. This PR doesn't update the snapshots, just the tests under sdk/.
Ping @kenrussell; we discussed this briefly over email a while ago. @littledan @leobalter