Add case for default fbo content would not changed between two readPxels calls. #2354
Conversation
|
This case is testing for https://codereview.chromium.org/2597933002/ |
| @@ -1,3 +1,3 @@ | |||
| read-pixels-pack-alignment.html | |||
| read-pixels-test.html | |||
|
|
|||
| fbo-remains-unchanged-after-read-pixels.html | |||
There was a problem hiding this comment.
Please add 1.0.4 condition to the new test
There was a problem hiding this comment.
@zhenyao , why need to add 1.0.4 for the new test? Is the reason that it is CMAA special case.
There was a problem hiding this comment.
All new tests should have the min version condition so that browsers passing older version of conformance won't regress; it's also for bookkeeping purpose so people know this is a newly added tests after 1.0.3 snapshot.
There was a problem hiding this comment.
I had added the min version for this test, please help to review it again, thank you.
| @@ -1,3 +1,3 @@ | |||
| read-pixels-pack-alignment.html | |||
| read-pixels-test.html | |||
|
|
|||
| --min-version 1.0.4 fbo-remains-unchanged-after-read-pixels.html | |||
There was a problem hiding this comment.
Sorry I didn't catch this earlier, but please follow alphabetical order.
There was a problem hiding this comment.
Sorry, late reply for vacation. I had ordered these files according alphabetical order.
…xels calls. It seems that every readPixels call will trigger CMAA operation in Chromium if CMAA is enabled. If there are not drawing operations between two readPixels calls, fbo content should not be changed.
|
lgtm |
|
lgtm after mass. Thanks! |
…xels calls. (KhronosGroup#2354) It seems that every readPixels call will trigger CMAA operation in Chromium if CMAA is enabled. If there are not drawing operations between two readPixels calls, fbo content should not be changed.
It seems that every readPixels call will trigger CMAA operation in
Chromium if CMAA is enabled. If there are not drawing operations
between two readPixels calls, fbo content should not be changed.