Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance test script #2361

Merged
merged 1 commit into from Oct 7, 2017
Merged

Add conformance test script #2361

merged 1 commit into from Oct 7, 2017

Conversation

gyagp
Copy link
Contributor

@gyagp gyagp commented Apr 5, 2017

This script is to run any version of Khronos WebGL conformance test on
various OSes (like Android, ChromeOS, Linux, MacOS and Windows) with
various browsers (like Chrome, Edge, FireFox, Safari, etc.). Results
will be compared with expectations and a final report will be generated.

This script is to run any version of Khronos WebGL conformance test on
various OSes (like Android, ChromeOS, Linux, MacOS and Windows) with
various browsers (like Chrome, Edge, FireFox, Safari, etc.). Results
will be compared with expectations and a final report will be generated.
@gyagp
Copy link
Contributor Author

gyagp commented Apr 5, 2017

@kenrussell, sorry that this has taken a bit longer as I almost rewrote my script, added more features, and enhanced the performance. Now all the main OSes, including Android, ChromeOS, Linux, MacOS and Windows, have at least support of 1 or 2 browsers, including Chrome, Edge, FireFox and Safari. For sure, there are many todos, but I think it's already good enough for first cut. For more details, please see the README.md enclosed.
Please suggest on folder and file names, on which I don't have a good idea yet. And now I put all the things in a single script, which might be handy for testing, but also be evil for code maintenance.
Please also comment on the detailed code and some general issues like coding style, etc.
Thanks!

@kenrussell
Copy link
Member

Yang, thanks for this tremendous contribution and I'm very sorry for sitting on it so long unreviewed. Finally set it up locally and ran it; it's working well. Let's do further improvements as follow-on pull requests.

For the record, was able to launch tests in Chrome via:

python conformance.py --browser-path /Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --browser-name Chrome --suite conformance/attribs

Merging now. Thanks again.

@kenrussell kenrussell merged commit 9536e75 into KhronosGroup:master Oct 7, 2017
@gyagp
Copy link
Contributor Author

gyagp commented Oct 9, 2017

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants