Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that samplers' state doesn't leak across contexts. #2383

Merged

Conversation

kenrussell
Copy link
Member

Regression test for http://crbug.com/713127 .

@kenrussell
Copy link
Member Author

@kainino0x in particular please review.

@zhenyao @jdashg and others: FYI.

Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenrussell
Copy link
Member Author

Merging in order to be able to start running this test on our automated test systems.

@kenrussell kenrussell merged commit f7157c2 into KhronosGroup:master Apr 25, 2017
@kenrussell kenrussell deleted the sampler-multi-context-test branch April 25, 2017 22:48
MXEBot pushed a commit to mirror/chromium that referenced this pull request Apr 27, 2017
Tested with new WebGL conformance test being added in
KhronosGroup/WebGL#2383 .

BUG=713127
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2837213003
Cr-Commit-Position: refs/heads/master@{#467520}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants