Add uniform buffer subtests exposing ANGLE bugs #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests pass on ANGLE's GL backend but failed on the DX backend until very recent fixes.
Oletus
force-pushed
the
structs-in-interface-blocks-test
branch
from
54a66b1
to
19bff4d
Compare
|
LGTM with a request for linking to the ANGLE bug. |
zhenyao
reviewed
Aug 14, 2017
| wrapper_t UBOStruct; | ||
| }; | ||
|
|
||
| // This is intended to reproduce a specific ANGLE bug that triggers when the wrapper struct is passed to a function. |
There was a problem hiding this comment.
Could you add a reference link to the ANGLE bug here?
| color_t UBOColors[2]; | ||
| }; | ||
|
|
||
| // This is intended to reproduce a specific ANGLE bug that triggers when a struct from an array of structs in an interface block is passed to a function. |
There was a problem hiding this comment.
Could you add a reference link to the ANGLE bug here?
|
Added the bug links, merging. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests pass on ANGLE's GL backend but failed on the DX backend
until very recent fixes.