Test for signed int attribs conversion #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test verifies that a WebGL 2 implementation converts singed integer vertex attributes using zero-presering rule as it's required to the GLES 3 spec.
kenrussell
reviewed
Aug 30, 2017
There was a problem hiding this comment.
Thanks for this test and sorry for taking so long to review it. It looks OK; tested locally. I'll update #2486 in response. Could you please make a few small changes?
| @@ -1,4 +1,5 @@ | |||
| gl-vertex-attrib.html | |||
| gl-vertex-attrib-i-render.html | |||
| gl-vertex-attrib-normalized-int.html | |||
There was a problem hiding this comment.
Please add --min-version 2.0.1
| @@ -0,0 +1,98 @@ | |||
| <!-- | |||
| /* | |||
| ** Copyright (c) 2015 The Khronos Group Inc. | |||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>WebGL 2 Normalized Vertex Attrbiutes Conformance Test</title> |
| }()); | ||
| </script> | ||
| <script> | ||
| description('Verify that conversion of normalized singed int attributes to floats uses zero-preserving rule.'); |
| <html> | ||
| <head> | ||
| <title>WebGL 2 Normalized Vertex Attrbiutes Conformance Test</title> | ||
| <meta charset="utf-8"> |
There was a problem hiding this comment.
Could you also add:
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
Review fixes.
|
Fixed:) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test verifies that a WebGL 2 implementation converts singed integer
vertex attributes using zero-presering rule as it's required to the
GLES 3 spec.
See also #2486.
/cc @kenrussell @zhenyao