New tests for texImage* with visible webgl canvas #2494
Conversation
|
Is it possible to modify the existing tex-image-and-sub-image-2d-with-webgl-canvas.js and tex-image-and-sub-image-3d-with-webgl-canvas.js to cover the visible webgl canvas case? So they cover both invisible and visible webgl canvas. That could avoid adding a large set of new tests being added. |
|
+1 to Mo's suggestion. Could you please modify the existing tex-image-and-sub-image-*-with-webgl-canvas harnesses to cover this case (run the tests twice, or run them twice for a subset of formats) instead of duplicating both the harnesses and the tests? Thanks. |
|
Done. I modified existing tests instead of creating new ones. |
| var canvas = ctx.canvas; | ||
| // Note: We use preserveDrawingBuffer:true to prevent canvas | ||
| // visibility from interfering with the tests. | ||
| var ctx = wtu.create3DContext(null, { preserveDrawingBuffer:true }); |
There was a problem hiding this comment.
Can we only set preserveDrawingBuffer:true for the test cases where visible: true? This can be easily done by creating another canvas.
Otherwise we lose test coverage.
| var ctx = wtu.create3DContext(); | ||
| // Note: We use preserveDrawingBuffer:true to prevent canvas | ||
| // visibility from interfering with the tests. | ||
| var ctx = wtu.create3DContext(null, { preserveDrawingBuffer:true }); |
| @@ -214,17 +216,29 @@ function generateTest(internalFormat, pixelFormat, pixelType, prologue, resource | |||
| function runTest() | |||
| { | |||
| var ctx = wtu.create3DContext(); | |||
| var canvas = ctx.canvas; | |||
| canvas = ctx.canvas; | |||
There was a problem hiding this comment.
Sorry, but you removed the var here.
|
Thank you! |
The new tests cover cases when the source image for a texture upload
is a visible WebGL canvas. When the canvas is visible (in the DOM)
it gets presented to screen, which alters internal state, which can be a
source of buggy behavior.
Related chrome bug: crbug.com/759180