Make renderbufferStorageMultisample with DEPTH_STENCIL and samples>0 generate INVALID_OPERATION. #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other option is to make |
|
This is a resolution for #2902. |
|
My preference would be to reject the unsized DEPTH_STENCIL enum with samples > 0 with INVALID_OPERATION. Would you please consider updating the test to assert that instead? We'll be happy to change Chrome's implementation to generate INVALID_OPERATION instead of INVALID_ENUM to follow. CC @jdarpinian @shrekshao for any thoughts. |
|
Sure! |
…generate INVALID_OPERATION.
kdashg
force-pushed
the
multisampled-DEPTH_STENCIL
branch
from
86c53f2
to
6f63c89
Compare
kdashg
changed the title
|
PTAL! |
kenrussell
approved these changes
Mar 6, 2020
|
@jdarpinian @shrekshao heads up that we need to file a bug about changing this validation in Chrome because this test will start failing during the next conformance roll. |
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Oct 29, 2020
WebGL2 does not allow allocating multisample renderbuffers with the GL_DEPTH_STENCIL format but Chrome has been generating the wrong error since the WebGL test was updated in KhronosGroup/WebGL#3031. TBR=kbr@chromium.org Bug: chromium:1082455 Bug: angleproject:5227 Change-Id: Ia9818968578a47023958c35c9b037e8907f76091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498111 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822304}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
WebGL2 does not allow allocating multisample renderbuffers with the GL_DEPTH_STENCIL format but Chrome has been generating the wrong error since the WebGL test was updated in KhronosGroup/WebGL#3031. TBR=kbr@chromium.org Bug: chromium:1082455 Bug: angleproject:5227 Change-Id: Ia9818968578a47023958c35c9b037e8907f76091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498111 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822304} GitOrigin-RevId: bd3558e3a9fd6f96c938a47f5467d9b765c641d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox allows DEPTH_STENCIL with samples >= 0.
Chrome allows samples==0, but INVALID_ENUM for samples >= 1.