Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawingBufferColorSpace/unpackColorSpace attributes to WebGLRenderingContextBase. #3292

Merged
merged 6 commits into from May 7, 2022

Conversation

kenrussell
Copy link
Member

@kenrussell kenrussell commented Jun 15, 2021

Define their behavior both for presenting the rendering context's
results, and uploading textures via texImage2D / texSubImage2D from
DOM inputs (the TexImageSource union type).

Follows whatwg/html#6562 , in which the
PredefinedColorSpace enum was defined, and its behavior for 2D canvas
contexts specified.

Define its behavior both for presenting the rendering context's
results, and uploading textures via texImage2D / texSubImage2D from
DOM inputs (the TexImageSource union type).

Follows whatwg/html#6562 , in which the
PredefinedColorSpace enum was defined, and its behavior for 2D canvas
contexts specified.
@kenrussell kenrussell requested a review from kdashg June 15, 2021 18:23
@kenrussell
Copy link
Member Author

@jdashg @ccameron-chromium @RafaelCintron in particular (active participants in the ColorWeb CG), please take a look.

specs/latest/1.0/index.html Outdated Show resolved Hide resolved
specs/latest/1.0/index.html Outdated Show resolved Hide resolved
context is uploaded or drawn to another one.
Reallocate drawing buffer when drawingBufferColorSpace is changed.
@kenrussell kenrussell changed the title Add colorSpace attribute to WebGLRenderingContextBase. Add drawingBufferColorSpace/unpackColorSpace attributes to WebGLRenderingContextBase. Mar 24, 2022
specs/latest/1.0/index.html Outdated Show resolved Hide resolved
@kdashg
Copy link
Contributor

kdashg commented Apr 20, 2022

For ease of use, we should consider taking a context creation attrib for colorSpace, and filling these attribs in from that initial value. We should probably exclude it from getContextAttributes, though, since those are immutable results.

@ccameron-chromium
Copy link
Contributor

For ease of use, we should consider taking a context creation attrib for colorSpace, and filling these attribs in from that initial value. We should probably exclude it from getContextAttributes, though, since those are immutable results.

That SGTM.

Make unpackColorSpace apply to ImageBitmaps and add rationale.
@kenrussell
Copy link
Member Author

For ease of use, we should consider taking a context creation attrib for colorSpace, and filling these attribs in from that initial value. We should probably exclude it from getContextAttributes, though, since those are immutable results.

That SGTM.

@kdashg @ccameron-chromium sounds fine; let's do that in a follow-up since we have agreement on the rest of this PR at the moment.

@kenrussell
Copy link
Member Author

All conversations resolved, and approved - squashing and merging.

@kenrussell kenrussell merged commit 2be1eff into KhronosGroup:main May 7, 2022
@kenrussell kenrussell deleted the add-colorspace branch May 7, 2022 01:00
kenrussell pushed a commit that referenced this pull request May 16, 2022
kenrussell pushed a commit that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants