Test all draw functions fail if attributes are invalid #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrussell
reviewed
Jul 16, 2022
There was a problem hiding this comment.
Nice work @greggman figuring out how to refactor these tests to apply the invalid vertex attribute tests to all draw functions.
In testing this locally I found a couple of bugs that happen when extensions weren't supported. I'll push a commit to this PR shortly which fixes these, the merge conflicts, and one other bug, for you to review.
sdk/tests/conformance2/extensions/webgl-multi-draw-instanced-base-vertex-base-instance.html
Outdated
Show resolved
Hide resolved
sdk/tests/conformance2/extensions/webgl-multi-draw-instanced-base-vertex-base-instance.html
Outdated
Show resolved
Hide resolved
|
|
ATM this test only tests if an attribute is enabled but no buffer is bound that each draw function generates INVALID_OPERATION Not sure what else needs to be tested. Maybe mis-matching attributes (an ivec4 attribute in shader but float attribute in vao) Fixes KhronosGroup#3434.
kenrussell
force-pushed
the
invalid-atrrib-tests
branch
from
53bd96b
to
a1fb5ac
Compare
kenrussell
approved these changes
Jul 16, 2022
There was a problem hiding this comment.
Thanks again @greggman for this improvement and apologies for taking so long to review it. These revised tests pass in Chrome, Firefox and Safari, modulo a couple of WEBGL_multi_draw failures in Safari Technology Preview which I believe @lexaknyazev already fixed in WebKit/WebKit#1452 .
sdk/tests/conformance2/extensions/webgl-multi-draw-instanced-base-vertex-base-instance.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3434
ATM this test only tests if an attribute is enabled but
no buffer is bound that each draw function generates
INVALID_OPERATION
Not sure what else needs to be test. Maybe mis-matching attributes (an ivec4 attribute in shader but float attribute in vao)