Fix async portions of PLS test. #3562
Conversation
Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest(). Follow-on to KhronosGroup#3530 .
|
@csmartdalton please feel free to review too. |
| await checkRendering(gl); | ||
| await checkRendering(gl_no_alpha); | ||
|
|
||
| finishTest(); |
There was a problem hiding this comment.
Just for my own understanding, how does the test harness know that the test is async now and that it should wait for finishTest? Before was it assuming the test was over as soon as it finished parsing?
There was a problem hiding this comment.
js-test-post.js notifies the test harness explicitly. When included statically, it's called as soon as the parsing is finished. With finishTest, the same script is added on the fly.
|
@kenrussell Please add another |
Timeouts were accidentally introduced in the last commit by failing to do this. Follow-on to KhronosGroup#3562 and KhronosGroup#3530.
Thanks for catching that. Fixing in #3563 . |
* Call finishTest() when PLS isn't supported. Timeouts were accidentally introduced in the last commit by failing to do this. Follow-on to #3562 and #3530. Fixed bugs caught by @lexaknyazev in code review.
Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest().
Follow-on to #3530 .