Test I420 JPEG -> ImageDecoder -> VideoFrame -> WebGLTexture. #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration (specifically, an I420 encoded JPEG) was broken in Chromium. Other red/green tests with different file formats can be added to the same test case later if desired. Associated with Chromium bug crbug.com/328284177 .
kenrussell
force-pushed
the
image-decoder-to-texture-test
branch
from
f6a12b7
to
c554baf
Compare
|
Updated test to check for ImageDecoder API and verified it's properly skipped in Safari Technology Preview and Firefox Nightly. |
kkinnunen-apple
approved these changes
Apr 11, 2024
kdashg
approved these changes
Apr 11, 2024
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
May 4, 2024
The test was fetching nonexistent "width" and "height" properties on the VideoFrame, leading to a (0, 0)-sized texture upload. codedWidth and codedHeight are the best approximation without handling the full visibleRect in the test. Follow-on to KhronosGroup#3641 . Associated with Chromium bug crbug.com/337904214 .
kenrussell
added a commit
that referenced
this pull request
May 4, 2024
The test was fetching nonexistent "width" and "height" properties on the VideoFrame, leading to a (0, 0)-sized texture upload. codedWidth and codedHeight are the best approximation without handling the full visibleRect in the test. Follow-on to #3641 . Associated with Chromium bug crbug.com/337904214 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration (specifically, an I420 encoded JPEG) was broken in Chromium. Other red/green tests with different file formats can be added to the same test case later if desired.
Associated with Chromium bug crbug.com/328284177 .