Test OffscreenCanvas.transferToImageBitmap compositing steps (#3612) #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkinnunen-apple
force-pushed
the
offscreen-transfer-to-image-bitmap-1
branch
from
a00b946
to
1d65f4f
Compare
kkinnunen-apple
changed the title
kkinnunen-apple
force-pushed
the
offscreen-transfer-to-image-bitmap-1
branch
2 times, most recently
from
3044345
to
44dde59
Compare
…Group#3612) Test following spec clarifications: * the value of preserveDrawingBuffer will have no effect * the contents of any depth and/or stencil buffers will be cleared to initial values
kkinnunen-apple
force-pushed
the
offscreen-transfer-to-image-bitmap-1
branch
from
44dde59
to
23e0cc2
Compare
kdashg
approved these changes
May 2, 2024
| gl.bindAttribLocation(p, 0, "a_pos"); | ||
| gl.linkProgram(p); | ||
| gl.useProgram(p); | ||
| gl.viewport(0, 0, 128, 128); |
There was a problem hiding this comment.
Suggested change
| gl.viewport(0, 0, 128, 128); | |
| gl.viewport(0, 0, gl.canvas.width, gl.canvas.height); |
There was a problem hiding this comment.
It's nice to hardcode fewer things.
kenrussell
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test following spec clarifications: