Make sure oes-element-index-uint test queries for attribute locations before binding #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hang on -- WebGLTestUtils.loadStandardProgram (webgl-test-utils.js) calls bindAttribLocation to set up a_vertex and a_normal. Can you please double-check your implementation? |
|
User error. Nothing to see here. |
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
…r r156351 or 156352 https://bugs.webkit.org/show_bug.cgi?id=121863 <rdar://problem/15069481> Reviewed by Beth Dakin. This test was not querying the vertex attribute locations before binding data to them. When we enabled symbol mangling we started seeing attributes appear in a different order than the order defined in the shader source. Update this test to ask getAttribLocation first. Note that there are two important issues. Firstly, this is updating our local copy of the Khronos test. I've opened pull request #377 to get it addressed in the source. KhronosGroup/WebGL#377 Secondly, this indicates that we might have a lot of problems with existing content that does not expect the order of attributes to change. * webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html: * TestExpectations: Unskip test. Canonical link: https://commits.webkit.org/139878@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently enabled symbol name mangling in WebKit and noticed that this particular test was assuming that the attribute indices match the order they appear in the shader. There are many tests that do the same, but this was the only one I hit that actually changed order (I might hit more on other hardware).
In general though I'm not sure whether I should do something in WebKit to avoid this. I expect there is a lot of existing content that does not check attribute locations before binding.