Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for miscellaneous parameters. #747

Merged
merged 1 commit into from Oct 13, 2014
Merged

Add tests for miscellaneous parameters. #747

merged 1 commit into from Oct 13, 2014

Conversation

dvander
Copy link
Contributor

@dvander dvander commented Oct 11, 2014

No description provided.

texture-npot.html
misc-parameters.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize this list. Thanks.

@kenrussell
Copy link
Member

Couple of minor questions / nits.

@dvander
Copy link
Contributor Author

dvander commented Oct 13, 2014

No reason other than force of habit in not polluting the global object. Doesn't matter here though so I removed it (and addressed the alphabetization as well).

@dvander
Copy link
Contributor Author

dvander commented Oct 13, 2014

Snuck in tests for two more parameters.

@toji
Copy link
Member

toji commented Oct 13, 2014

LGTM

toji added a commit that referenced this pull request Oct 13, 2014
Add tests for miscellaneous parameters.
@toji toji merged commit 3b7514a into KhronosGroup:master Oct 13, 2014
@dvander dvander deleted the misc-parameters branch October 13, 2014 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants