Add getBufferSubData test #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests the function getBufferSubData and its restrictions in WebGL 2.0
|
|
||
| debug(""); | ||
| debug("Test that getBufferSubData successfully works reading buffer data from gl.ARRAY_BUFFER"); | ||
| var arrBuffer = new ArrayBuffer(vertices.length * 4); |
There was a problem hiding this comment.
This would be better written as new ArrayBuffer(floatArray.byteLength).
There was a problem hiding this comment.
(because of the constant "4". Float32Array.BYTES_PER_ELEMENT would be better at least.)
|
Thanks for this contribution. It looks good overall. Could you please add it to 00_test_list.txt as well as address the feedback above? Please ask toji or zhenyao to do the final review and merge. Thanks. |
|
Test looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the function getBufferSubData and its restrictions in WebGL 2.0