-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional models to the Animation_Skin model group #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zoom in on skinA models
… >4 joint vertex influences
stevk
changed the title
Skinbuilder
Add additional models to the Animation_Skin model group
Oct 25, 2018
bghgary
requested changes
Oct 26, 2018
11 tasks
bghgary
reviewed
Nov 8, 2018
bghgary
reviewed
Nov 8, 2018
…ointweight sets in the converter
bghgary
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/stevk/glTF-Asset-Generator/tree/skinbuilder/Output/Animation_Skin
Adds three models to Animation_Skin.
MODEL 06 - Multiple meshes sharing a single skin. (Sharing skeletons between two skinned mesh glTF#1285)
MODEL 07 - Joint hierarchy has no common root. ([Clarification] Skeleton root and joints hierarchy glTF#1270)
As discussed, the skeleton property should probably be removed, and can already be ignored by implementations. In addition to that, we should have an example asset for which no common root is possible (e.g. bones form two subtrees starting from the scene root).
not skeleton property is kept.
MODEL 12 - Many (>4) joint vertex influences. (Skinning influenced by more than 4 joints glTF#1381)
As a part of this PR, this also:
Fixes #459 and #396