Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional models to the Animation_Skin model group #465

Merged
merged 23 commits into from
Nov 9, 2018

Conversation

stevk
Copy link
Contributor

@stevk stevk commented Oct 25, 2018

https://github.com/stevk/glTF-Asset-Generator/tree/skinbuilder/Output/Animation_Skin

Adds three models to Animation_Skin.

As a part of this PR, this also:

  • Fixes SampleImageHelper so that it correctly uses provided screenshots when we want to override the generated one
  • Creates a ModelGroup_Skinbuilder class that is used to dynamically generate several of the skins and mesh's used by Animation_Skin.
  • Added support for setting camera position in the manifest on a per-model basis, and updated all of the skins models to take advantage of this.

Fixes #459 and #396

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2018

CLA assistant check
All committers have signed the CLA.

@stevk stevk changed the title Skinbuilder Add additional models to the Animation_Skin model group Oct 25, 2018
@stevk stevk requested review from kcoley and bghgary October 25, 2018 18:05
@stevk stevk self-assigned this Oct 25, 2018
Source/Manifest.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/ModelGroups/Animation_Skin.cs Outdated Show resolved Hide resolved
Source/ModelGroups/Animation_Skin.cs Outdated Show resolved Hide resolved
Source/ModelGroups/Animation_Skin.cs Outdated Show resolved Hide resolved
Source/ModelGroups/Animation_SkinType.cs Outdated Show resolved Hide resolved
Source/Runtime/GLTFConverter.cs Outdated Show resolved Hide resolved
Source/Manifest.cs Outdated Show resolved Hide resolved
Source/ModelGroup_Prism.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/Runtime/GLTFConverter.cs Outdated Show resolved Hide resolved
Source/Runtime/GLTFConverter.cs Outdated Show resolved Hide resolved
Source/Vec3ToFloatArrayJsonConverter.cs Outdated Show resolved Hide resolved
Source/Vec3ToFloatArrayJsonConverter.cs Outdated Show resolved Hide resolved
Source/Vec3ToFloatArrayJsonConverter.cs Outdated Show resolved Hide resolved
Source/ModelGroup_SkinBuilder.cs Outdated Show resolved Hide resolved
Source/Runtime/GLTFConverter.cs Outdated Show resolved Hide resolved
Source/Runtime/GLTFConverter.cs Outdated Show resolved Hide resolved
@stevk stevk merged commit 7148331 into KhronosGroup:master Nov 9, 2018
@stevk stevk deleted the skinbuilder branch November 9, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants