Export vtree #1378

julienduroure · 2021-04-18T16:45:43Z

No description provided.

for mesh & material Use custom key cache by scurest Use id of mesh & material

julienduroure · 2021-04-18T16:47:20Z

Still a WIP.
This is only a first step: Have a virtual Tree for nodes, and then use this tree to construct glTF tree.

Still have some TODO to manage, because managing skin & joints with this current system is not easy

julienduroure · 2021-05-20T04:58:19Z

Seems tests are KO only for pull_request because a cache issue (still caching 2.93 where push caches 3.0)
Anyone know how to solve it?

julienduroure · 2021-06-29T17:22:59Z

2 different new things in this branch:

manage a tree before export. It uses an uuid for each "real" object, and these uuid are passed to other function (and can be used for caching)
Using custom caching, as proposed by scurest. Already used in some cases here.

In current version:

All tested collection instance issues are solved
No more proxy check is needed (for example Text and Mesh using same name in different linked data are now ok)

In attachment a test case for multi level collection instance, for materials, and meshes

collections.zip
materials.zip
mesh.zip

Of course lots of work are still needed, but this is a first step.

…pplied

…animation

emackey · 2022-02-11T14:45:49Z

@julienduroure I tried exporting a model with multiple same-name NLA tracks, using a vtree build from today. It looks like all my parts came out animated separately. I have "Group by NLA track" checked, but it didn't perform any grouping, they all came out as loose pieces.

This was a complex model that I can't share, but I could try building a reduced test model if needed.

julienduroure · 2022-02-11T15:22:58Z

@emackey Do you have your .blend test case?
I can't reproduce here for now on simple test case

emackey · 2022-02-11T16:39:37Z

Took a while to figure out how to reproduce, but it turns out the bug activates when "Include Selected Objects" is checked in the exporter options. The combined NLA track exports alongside loose animations per-object.

NLA_Test_vtree.zip

In the above example, there should be only one NLA animation exported, called "CubeDance." But when "Include Selected Objects" is used, the combined animation appears alongside individual cube animations.

julienduroure · 2022-02-11T18:43:26Z

@emackey Nice catch!
I just pushed a fix, and ask builder to compile a new build. Should be available in a few hours

emackey · 2022-02-11T22:13:00Z

Confirmed fix. Thanks!

s-light · 2022-02-16T14:46:03Z

just tried and got an error if there is a animation
test_cube_animation.zip
i also checked if it has to do do with any other option:

    use_selection=False,
    export_animations=True,
    export_nla_strips=True,
    export_frame_range=True,

only the export_animations=xxx makes a difference - if False the export is fine. if True the following error pops up:

Info: Saved "test_cube_animation.blend"

... truncated'/home/stefan/mydata/tools/blender/blender-3.0.0-linux-x64/3.0/python/lib/python3.9/site-packages/libextern_draco.so' exists, draco mesh compression is available
14:45:11 | INFO: Starting glTF 2.0 export
14:45:11 | INFO: Extracting primitive: Cube
14:45:11 | INFO: Primitives created: 1
Python: Traceback (most recent call last):
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/__init__.py", line 640, in execute
    return gltf2_blender_export.save(context, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 46, in save
    json, buffer = __export(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 63, in __export
    __gather_gltf(exporter, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 77, in __gather_gltf
    active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py", line 44, in gather_gltf2
    animations += __gather_animations(blender_scene, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py", line 99, in __gather_animations
    animations_, merged_tracks = gltf2_blender_gather_animations.gather_animations(obj_uuid, merged_tracks, len(animations), export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 124, in gather_animations
    animation = __gather_animation(obj_uuid, blender_action, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 165, in __gather_animation
    channels=__gather_channels(obj_uuid, blender_action, export_settings),
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 202, in __gather_channels
    return gltf2_blender_gather_animation_channels.gather_animation_channels(
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_cache.py", line 49, in wrapper_cached
    result = func(*args, **kwargs)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animation_channels.py", line 48, in gather_animation_channels
    if blender_action.use_frame_range is True:
AttributeError: 'Action' object has no attribute 'use_frame_range'

location: /home/stefan/mydata/tools/blender/blender-3.0.0-linux-x64/3.0/scripts/modules/bpy/ops.py:132
Error: Python: Traceback (most recent call last):
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/__init__.py", line 640, in execute
    return gltf2_blender_export.save(context, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 46, in save
    json, buffer = __export(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 63, in __export
    __gather_gltf(exporter, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 77, in __gather_gltf
    active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py", line 44, in gather_gltf2
    animations += __gather_animations(blender_scene, export_settings)
  File "/home/stefan/.Traceback (most recent call last):
  File "/home/stefan/mydata/github/aframe_gltf_animation_player/models/test_cube_animation.blend/export.py", line 13, in <module>
  File "/home/stefan/mydata/tools/blender/blender-3.0.0-linux-x64/3.0/scripts/modules/bpy/ops.py", line 132, in __call__
    ret = _op_call(self.idname_py(), None, kw)
RuntimeError: Error: Python: Traceback (most recent call last):
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/__init__.py", line 640, in execute
    return gltf2_blender_export.save(context, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 46, in save
    json, buffer = __export(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 63, in __export
    __gather_gltf(exporter, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_export.py", line 77, in __gather_gltf
    active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py", line 44, in gather_gltf2
    animations += __gather_animations(blender_scene, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather.py", line 99, in __gather_animations
    animations_, merged_tracks = gltf2_blender_gather_animations.gather_animations(obj_uuid, merged_tracks, len(animations), export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 124, in gather_animations
    animation = __gather_animation(obj_uuid, blender_action, export_settings)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 165, in __gather_animation
    channels=__gather_channels(obj_uuid, blender_action, export_settings),
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animations.py", line 202, in __gather_channels
    return gltf2_blender_gather_animation_channels.gather_animation_channels(
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_cache.py", line 49, in wrapper_cached
    result = func(*args, **kwargs)
  File "/home/stefan/.config/blender/scripts/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_animation_channels.py", line 48, in gather_animation_channels
    if blender_action.use_frame_range is True:
AttributeError: 'Action' object has no attribute 'use_frame_range'

location: /home/stefan/mydata/tools/blender/blender-3.0.0-linux-x64/3.0/scripts/modules/bpy/ops.py:132


Error: Python script failed, check the message in the system console

julienduroure · 2022-02-16T15:46:02Z

@s-light You need at least 3.1 to run this branch, you can't use 3.0

julienduroure · 2022-02-16T15:48:46Z

@s-light You have a build here if you want : https://builder.blender.org/download/experimental/gltf_vtree/

s-light · 2022-02-16T15:51:43Z

sorry... is not related to vtree.
it also happens in the current master -
and after some digging i found that the used use_frame_range is a blender3.1 feature....

Capital-Asterisk · 2022-02-21T01:02:33Z

Hi, I just tried out these changes to fix my problems in #1576. I've noticed that skins are duplicated if multiple objects are parented to a single armature:

"skins" : [
    {
        "inverseBindMatrices" : 6,
        "joints" : [
            1,
            0
        ],
        "name" : "Armature"
    },
    {
        "inverseBindMatrices" : 6,
        "joints" : [
            1,
            0
        ],
        "name" : "Armature"
    }
],

I'm not sure if this is intentional, but this did not happen before. It may re-introduce #566, though this issue and its resolution seems complicated. Unlike the mentioned issue, the inverseBindMatrices are exactly the same in this case.

For some context, I'm writing a C++ application that uses gltf, and relies on nodes within the same armature to have the same skin; it would abort otherwise.

julienduroure · 2022-02-21T05:53:00Z

I've noticed that skins are duplicated if multiple objects are parented to a single armature

Confirmed. I will have a look soon

julienduroure · 2022-02-21T06:11:44Z

@Capital-Asterisk I just Fixed the duplicate skin data bug

julienduroure added 6 commits April 11, 2021 15:53

Custom cache key

8a42ab6

for mesh & material Use custom key cache by scurest Use id of mesh & material

Manage collections (and recursive collections)

8e2c99e

add missing parameter in armature animation workflow

fc28515

add TODO

b84840c

Construct VTree at export

4c7c98d

WIP

78d4757

julienduroure added 17 commits May 14, 2021 20:00

WIP, remove TODOTREE already managed

a00f5ef

WIP

ba191e3

WIP

b4a0778

WIP

4f0bae2

WIP

9965d68

WIP

27a518b

WIP

03ef835

WIP

b1b8193

Merge branch 'master' into export_vtree

e22b04b

WIP

dbfe475

Merge branch 'cache_custom_key' into export_vtree

a15b139

Remove proxy management, this is now done by Override

bc0364d

Fix bad merge

534392d

WIP - drivers

25b0e17

cleanup

c7b41e8

Merge branch 'master' into export_vtree

0fe0297

cleanup

120c583

scurest mentioned this pull request May 20, 2021

CI: old Blender version, cache issues #1320

Closed

Merge branch 'master' into export_vtree

cd9ec38

julienduroure added 2 commits July 4, 2021 17:58

Merge branch 'master' into export_vtree

3b0dade

remove not used instruction

a28a706

julienduroure added 3 commits February 10, 2022 05:17

when exporting with selection, bake in all cases to get constraints a…

97e0108

…pplied

Fix exporting without armature

17ac832

Exclude armature from baking object, as this will be done with joint …

f42e552

…animation

julienduroure mentioned this pull request Feb 10, 2022

Der macht super quatsch ! #1203

Closed

Fix range of animation bake

3bd1536

julienduroure added 2 commits February 11, 2022 19:35

Fix partial baking when there are some weight anim

0ae9142

Fix NLA grouping when baking because of selection

28205a9

julienduroure added 3 commits February 12, 2022 14:00

Merge branch 'master' into export_vtree

fde17ed

Merge branch 'master' into export_vtree

de833c8

Merge branch 'master' into export_vtree

fc70583

Capital-Asterisk mentioned this pull request Feb 20, 2022

Invalid glTF from exporting armatures linked across scenes #1576

Closed

Restore caching of skin data

283664a

Merge branch 'master' into export_vtree

a2b2833

julienduroure mentioned this pull request Feb 23, 2022

Ability to expose filter to extensions #1578

Closed

Fix merge issue

6ea9013

s-light mentioned this pull request Feb 28, 2022

objects from linked collections fail on export silverslade/aframe_blender_exporter#9

Open

Remove special generator tag of VTree

874233c

julienduroure merged commit 69746b2 into master Mar 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export vtree #1378

Export vtree #1378

julienduroure commented Apr 18, 2021

julienduroure commented Apr 18, 2021

julienduroure commented May 20, 2021

julienduroure commented Jun 29, 2021

emackey commented Feb 11, 2022 •

edited

Loading

julienduroure commented Feb 11, 2022

emackey commented Feb 11, 2022

julienduroure commented Feb 11, 2022

emackey commented Feb 11, 2022

s-light commented Feb 16, 2022 •

edited

Loading

julienduroure commented Feb 16, 2022

julienduroure commented Feb 16, 2022

s-light commented Feb 16, 2022

Capital-Asterisk commented Feb 21, 2022

julienduroure commented Feb 21, 2022

julienduroure commented Feb 21, 2022

Export vtree #1378

Export vtree #1378

Conversation

julienduroure commented Apr 18, 2021

julienduroure commented Apr 18, 2021

julienduroure commented May 20, 2021

julienduroure commented Jun 29, 2021

emackey commented Feb 11, 2022 • edited Loading

julienduroure commented Feb 11, 2022

emackey commented Feb 11, 2022

julienduroure commented Feb 11, 2022

emackey commented Feb 11, 2022

s-light commented Feb 16, 2022 • edited Loading

julienduroure commented Feb 16, 2022

julienduroure commented Feb 16, 2022

s-light commented Feb 16, 2022

Capital-Asterisk commented Feb 21, 2022

julienduroure commented Feb 21, 2022

julienduroure commented Feb 21, 2022

emackey commented Feb 11, 2022 •

edited

Loading

s-light commented Feb 16, 2022 •

edited

Loading