Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Add glTF 1.1 models from the upcoming glTF tutorial #16

Closed
pjcozzi opened this issue Dec 26, 2016 · 3 comments
Closed

Add glTF 1.1 models from the upcoming glTF tutorial #16

pjcozzi opened this issue Dec 26, 2016 · 3 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Dec 26, 2016

@javagl for the models in https://github.com/javagl/gltfTutorialModels, do you prefer:

  • That we just link to that repo from here, or
  • That you open a PR to move all those models into this repo and then perhaps add an appendix to the tutorial with a list of the models and direct links to each?
@javagl
Copy link
Contributor

javagl commented Dec 27, 2016

I don't have a strong preference here. Conceptually, they are a bit different than the other models, because they are small, hand-crafted, feature-based examples, and some of them use a mixed structure (with embedded buffers but external shaders) for easier presentation in the tutorial.

If they are moved to the official sample models repo, then they could

  • either appear as "Test cases/models" in a dedicated list
  • or be added to the list of existing models, possibly sorted by topic (e.g. the "SimpleAnimation" before "Box Animated", the "SimpleSkin" before "Rigged Simple" etc.)

In any case, I agree to what you mentioned in the second point: It could be useful to link from the tutorial to the models. Either via a list in an appendix, or inlined: "Here is an example ... it can be downloaded from the sample models repo at (link)". Similarly, one could add a link to the README of the models: "SimpleSkin. Skinning is explained in the tutorial at (link)"

If they should be added here, then just drop me a note, and I will create a PR to start filling the 1.1 directory :-)

@pjcozzi
Copy link
Member Author

pjcozzi commented Dec 28, 2016

either appear as "Test cases/models" in a dedicated list

Good idea, let's do this. Looking forward to the pull request!

javagl added a commit to javagl/gltfTutorialModels that referenced this issue Dec 30, 2016
Fixed file extension (.png -> .gif)

Thanks @cx20 (Note: The models in this repository are about to be copied to the official sample models repo, in view of KhronosGroup/glTF-Sample-Models#16 - I'm currently doing further tests, validations, cleanups and possibly a few minor renamings before issuing the pull request)
@javagl
Copy link
Contributor

javagl commented Jan 16, 2017

Done ("accidentally") as discussed in #18 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants