-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add glTF 1.1 models from the upcoming glTF tutorial #16
Comments
I don't have a strong preference here. Conceptually, they are a bit different than the other models, because they are small, hand-crafted, feature-based examples, and some of them use a mixed structure (with embedded buffers but external shaders) for easier presentation in the tutorial. If they are moved to the official sample models repo, then they could
In any case, I agree to what you mentioned in the second point: It could be useful to link from the tutorial to the models. Either via a list in an appendix, or inlined: "Here is an example ... it can be downloaded from the sample models repo at (link)". Similarly, one could add a link to the README of the models: "SimpleSkin. Skinning is explained in the tutorial at (link)" If they should be added here, then just drop me a note, and I will create a PR to start filling the 1.1 directory :-) |
Good idea, let's do this. Looking forward to the pull request! |
Fixed file extension (.png -> .gif) Thanks @cx20 (Note: The models in this repository are about to be copied to the official sample models repo, in view of KhronosGroup/glTF-Sample-Models#16 - I'm currently doing further tests, validations, cleanups and possibly a few minor renamings before issuing the pull request)
Done ("accidentally") as discussed in #18 (comment) |
@javagl for the models in https://github.com/javagl/gltfTutorialModels, do you prefer:
The text was updated successfully, but these errors were encountered: