-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
1.0/genBinaryMC.sh
Outdated
@@ -0,0 +1,17 @@ | |||
# adjust according to actual installation path of gltf-pipeline | |||
alias gltfpipe="node /home/user/ehome/projects/gltf/gltf-pipeline-master/bin/gltf-pipeline.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use an npm dependency instead of a user-specific path here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the style of the existing convertAll.sh script.
Perhaps just remove the script to avoid confusion ?
Since I am unsure how to use an npm dependency here, I just commented the alias and added an explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script is bit more complicated/strange because gltfpipe insisted on its 'output' directory.
If there is anything I can help with, I would be glad to. |
Hi @andreasplesch, sorry this fell through the cracks. I don't think much/any effort is being put back into 1.0 now that glTF 2.0 is in full swing. I don't think we need to include more permutations of 1.0 models here. Also I'm mildly opposed to just automatically applying all permutations of extensions to all models; instead I think it would be more useful to have a specific example of each Khronos-ratified extension, showing how that extension is best used for some purpose that a core glTF model can't replicate. |
cx20/gltf-test#17 |
I'll admit I haven't been following MC very closely, but I think the current work is being done in KhronosGroup/glTF#1163. My concerns here are, in no particular order:
Sorry for raining on the parade. But I think it's best to focus our efforts on making sure that 2.0 and its extensions can be made to cover use-cases that 1.0/MC used to cover. (@cx20 feel free to chime in if you have opinions on this too, thanks!) |
JSYK, 1.0/MC has never been finished. |
Oh well, so be it. |
I just noticed the
samples wanted
label in #109, so here we go.