Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Add dragon attenuation model. #306

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Add dragon attenuation model. #306

merged 7 commits into from
Jun 11, 2021

Conversation

emackey
Copy link
Member

@emackey emackey commented Apr 7, 2021

See the README.

@emackey
Copy link
Member Author

emackey commented Apr 7, 2021

Things to consider here:

  • Scale the thicknessFactor from 3.5 to 2.2, and scale attenuationDistance by the same percentage. This would get the thicknessFactor to more closely match the raw vertex distances at the thickest portion of the dragon's body.
  • Change the thickness texturemap here to only use the green channel, to make sure implementations are reading from the correct channel. The AttenuationTest model handles this test now.

@emackey
Copy link
Member Author

emackey commented Apr 8, 2021

Actually I'm not sure 2.2 is the thickest part, it looks like some lower parts are above 3.0. Would be interesting to compare to the path tracer if they add support for attenuation there.

@emackey
Copy link
Member Author

emackey commented Apr 9, 2021

Also:

  • Add "common problems" section with a screenshot of what happens when the node scaling is not accounted for.

@emackey
Copy link
Member Author

emackey commented Jun 7, 2021

This is ready for review.

2.0/README.md Outdated Show resolved Hide resolved
Co-authored-by: abwood <abwood@gmail.com>
Copy link
Contributor

@abwood abwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great model and fantastic writeup. Thanks @emackey!

@abwood abwood merged commit d14f241 into master Jun 11, 2021
@abwood abwood deleted the dragon-attenuation branch June 11, 2021 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants