Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appendix to EXT_mesh_gpu_instancing. #1821

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Add appendix to EXT_mesh_gpu_instancing. #1821

merged 5 commits into from
Oct 25, 2020

Conversation

donmccurdy
Copy link
Contributor

@donmccurdy donmccurdy commented Jun 3, 2020 •
edited
Loading

Provides further detail on terminology, purpose, and current limitations of EXT_mesh_gpu_instancing.

/cc @ultrafishotoy @juj @vpenades @zeux

@donmccurdy donmccurdy changed the title Add appendix to KHR_mesh_gpu_instancing. Add appendix to EXT_mesh_gpu_instancing. Jun 3, 2020
@donmccurdy donmccurdy mentioned this pull request Jun 3, 2020
Merged
@donmccurdy
Copy link
Contributor Author

@ultrafishotoy @zeux @bghgary could one of you review this?

@donmccurdy
Copy link
Contributor Author

donmccurdy commented Jul 16, 2020 •
edited
Loading

As @zeux mentions there's a conflict, so let's merge #1820 before this PR.

@emackey
Copy link
Member

emackey commented Aug 6, 2020

@donmccurdy #1820 is merged now.

@donmccurdy donmccurdy force-pushed the donmccurdy-instancing-motivation branch from ed2b7e4 to db32e7a Compare October 17, 2020 18:34
@donmccurdy
Copy link
Contributor Author

Thanks for the feedback! I've rebased the PR and addressed all comments.

@lexaknyazev
Copy link
Member

"Overview" and "Extending Nodes With Instance Attributes" sections are formatted with extra line breaks (invisible when rendered) while the appendix doesn't use them. Should the document use the same style throughout?

@donmccurdy
Copy link
Contributor Author

donmccurdy commented Oct 17, 2020 •
edited
Loading

Unless there is a tool that can automatically create these line breaks at some column width, I wouldn't want to enforce them by hand — it becomes pretty tedious. I don't mind removing the line breaks, though. It sounds like AsciiDoc handles this pretty much the same way as Markdown?

@lexaknyazev
Copy link
Member

Yeah, AsciiDoc will merge consecutive lines too. My preference is to remove line breaks from Markdown files.

@donmccurdy
Copy link
Contributor Author

Ok, done.

@donmccurdy
Copy link
Contributor Author

@ultrafishotoy any objection to merging this? I believe the changes are purely explanatory.

@ultrafishotoy
Copy link
Contributor

ultrafishotoy commented Oct 24, 2020 via email

@donmccurdy donmccurdy merged commit 56cdef7 into master Oct 25, 2020
@donmccurdy donmccurdy deleted the donmccurdy-instancing-motivation branch October 25, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juj juj juj left review comments

@zeux zeux zeux left review comments

@bghgary bghgary bghgary left review comments

Assignees
No one assigned
Labels
extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@donmccurdy @emackey @lexaknyazev @ultrafishotoy @juj @zeux @bghgary