-
Notifications
You must be signed in to change notification settings - Fork 817
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HLSL: Add better diagnostic when using in/out qualifiers in global sc…
…ope (#2258)
- Loading branch information
Showing
4 changed files
with
61 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
hlsl.inoutquals.negative.frag | ||
ERROR: 0:1: 'invalid1' : in/out qualifiers are only valid on parameters | ||
ERROR: 0:2: 'invalid2' : in/out qualifiers are only valid on parameters | ||
ERROR: 0:3: 'invalid3' : in/out qualifiers are only valid on parameters | ||
ERROR: 0:4: 'invalid4' : in/out qualifiers are only valid on parameters | ||
ERROR: 4 compilation errors. No code generated. | ||
|
||
|
||
Shader version: 500 | ||
gl_FragCoord origin is upper left | ||
ERROR: node is still EOpNull! | ||
0:6 Function Definition: @main( ( temp void) | ||
0:6 Function Parameters: | ||
0:6 Function Definition: main( ( temp void) | ||
0:6 Function Parameters: | ||
0:? Sequence | ||
0:6 Function Call: @main( ( temp void) | ||
0:? Linker Objects | ||
0:? 'invalid1' ( in float) | ||
0:? 'invalid2' ( inout float) | ||
0:? 'invalid3' ( inout float) | ||
0:? 'invalid4' ( out float) | ||
|
||
|
||
Linked fragment stage: | ||
|
||
|
||
Shader version: 500 | ||
gl_FragCoord origin is upper left | ||
ERROR: node is still EOpNull! | ||
0:6 Function Definition: @main( ( temp void) | ||
0:6 Function Parameters: | ||
0:6 Function Definition: main( ( temp void) | ||
0:6 Function Parameters: | ||
0:? Sequence | ||
0:6 Function Call: @main( ( temp void) | ||
0:? Linker Objects | ||
0:? 'invalid1' ( in float) | ||
0:? 'invalid2' ( inout float) | ||
0:? 'invalid3' ( inout float) | ||
0:? 'invalid4' ( out float) | ||
|
||
SPIR-V is not generated for failed compile or link |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
in float invalid1; | ||
in out float invalid2; | ||
inout float invalid3; | ||
out float invalid4; | ||
|
||
void main() { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters