Fixing RECOM footprints, round 2.

[rschaeuble]

These files were regenerated with these changes to the generator:
pointhi/kicad-footprint-generator#141.

R5xxxDA (https://www.recom-power.com/pdf/Innoline/R-5xxxPA_DA.pdf):

R5xxxPA (https://www.recom-power.com/pdf/Innoline/R-5xxxPA_DA.pdf):

R-78B-2.0 (https://www.recom-power.com/pdf/Innoline/R-78Bxx-2.0.pdf):

R-78E-0.5 (https://www.recom-power.com/pdf/Innoline/R-78Exx-0.5.pdf):

R-78HB-0.5 (https://www.recom-power.com/pdf/Innoline/R-78HBxx-0.5_L.pdf):

R-78HB-0.5L (https://www.recom-power.com/pdf/Innoline/R-78HBxx-0.5_L.pdf):

R-78S-0.1 (https://www.recom-power.com/pdf/Innoline/R-78Sxx-0.1.pdf):

---

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the footprint(s) you are contributing
• An example screenshot image is very helpful
• If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Fix recom 2 kicad-packages3D#339
• Check the output of the Travis automated check scripts - fix any errors as required

[rschaeuble]

If someone could do a quick sanity check and compare the measurements in the screenshots with the ones in the datasheets, that would be awesome.

If no errors are pointed out in the next 2-3 days, I'll go and make the according changes to the 3D models as well (and link the PRs here).

[rschaeuble]

3D model changes are now available as well: KiCad/kicad-packages3D#339

[Shackmeister]

Shouldn't R5xxx be R-5xxx?

Also for
Converter_DCDC_RECOM_R-78HB-0.5L_THT
and
Converter_DCDC_RECOM_R5xxxDA_THT
A silk line going next to the pin 1 pad would be sufficient :)

[rschaeuble]

@Shackmeister: yes, to be 100% correct and consistent, the dashes in the names would have to be added. Should I do this in this PR (and add one for the symbols repo, as the footprint names there would have to be adapted), or should I make a separate PR after this one?

The thing with the silk lines I didn't understand. Could you elaborate?

[Misca1234]

The only very small thing I found was in Converter_DCDC_RECOM_R-78E-0.5_THT
The F.Fab distance to pin one is -3,31, it should be -3.21

Shackmeister means something like this (I guess), the pin 1 marker should go "outside the pin and not around the corner

[rschaeuble]

@Misca1234: I believe the -3.31 are correct.

The datasheet for the R-78E-0.5 specifies pin 3 to be 3.21 mm from the right side of the device. Pin 1 is 5.08 mm from pin 3, so it's 8.29 mm from the right side. With a width of 11.6 mm, pin 1 is 11.6 - 8.29 = 3.31 mm from the left side.

About the pin 1 marker: I think I understand what you mean, but I'll make a quick drawing to verify that with you tomorrow or Friday. I don't know, however, how easily that is changed in the generator script.

[Misca1234]

About the pin 1 marker: I think I understand what you mean, but I'll make a quick drawing to
verify that with you tomorrow or Friday. I don't know, however, how easily that is changed in the generator script.

It was my guess that it is what Shackmeister wanted, he have to confirm

[Shackmeister]

Im referering to this (and it's brother), the Pin 1 line is marked.

I think this style would be much more suited. line is marked again

[rschaeuble]

@Shackmeister: alright, I get it now.

Would this also be OK?

This way it looks similar to all the other RECOM packages (and, to be honest, it's less work ;-)).

Besides this, there is still the question of renaming R5xxx to R-5xxx? Should I do this in this PR, or open another one?

[rschaeuble]

I didn't get any feedback on the questions in my previous comment, so I went ahead and modified the footprints as I suggested.
Both the footprint generator and the footprints are updated; I also updated the screenshots of the R5xxxDA and the R-78HB-0.5L to show the changes.

If this is OK as it is, please merge. After the merge I will create a new PR to rename the R5xxx.

[poeschlr]

A bit late to the party but i must say i would like the pin 1 marker suggested by @Shackmeister a lot more than the L around the corner. That style would be closer to what industry standards suggest right now.

[rschaeuble]

@poeschlr alright, I made those changes, and updated the screenshots.

[rschaeuble]

@Shackmeister, @poeschlr: are there any issues left that are preventing this from getting merged?

[poeschlr]

I would guess just time for a proper review

[Misca1234]

I made a full review for some time ago, if it is only the pin 1 marker that have been changed we only need to look at that, or accept the current push as it is now right away

[rschaeuble]

@Misca1234 Yes, the pin 1 marker was the only thing I've changed.

I wouldn't mind if this got merged soon. As many of the old RECOM footprints are wrong anyway, the chance of making it worse isn't that biganyway ;-)

[Misca1234]

oh, it is eight of them, I will do it tomorrow

[Misca1234]

Everything looks good, however we need to update the 3D model for
Converter_DCDC_RECOM_R5xxxDA_THT

(the problem is the pins, they are not 90 degree but 45 degree which made the 3D model slightly offset)

[rschaeuble]

@Misca1234 please have a look at my pull request KiCad/kicad-packages3D#339. That PR contains fixes to the 3D models.

[rschaeuble]

@Misca1234 Please also merge pointhi/kicad-footprint-generator#141, which contains the changes to the generator that created these footprints.

[Misca1234]

I cant, I do not have any rights on that repository