This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Fix footprints of RECOM DC/DC converters. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…the front instead of towards the back, some had a wrong pin 1 offset, and other had wrong widths.Also refactored the script to put different families of controllers into different functions.
4 tasks
|
Code Climate has analyzed commit c583047 and detected 0 issues on this pull request. View more on Code Climate. |
|
The footprint changes have been merged, so this one can now also be merged. |
|
@pointhi: as the footprints have already been merged, could you please merge this pull request? |
|
@pointhi Is there anything that still needs to be done before this can be merged? As the footprints have already been merged, it would be great if the generator changes could be merged soon as well. |
|
@rschaeuble I will merge now. Thanks for your contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some had their pins towards the front instead of towards the back, some had a wrong pin 1 offset, and other had wrong widths.
Also refactored the script to put different families of controllers into different functions.
See KiCad/kicad-footprints#688 for the original pull request which triggered this one.