Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix footprints of RECOM DC/DC converters. #688

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Fix footprints of RECOM DC/DC converters. #688

merged 1 commit into from
Jun 24, 2018

Conversation

rschaeuble
Copy link
Contributor

@rschaeuble rschaeuble commented Jun 23, 2018

Fix footprints of RECOM DC/DC converters, where the 'bulge' was toward the back while it should have been to the front.

The footprints of two of the RECOM DC/DC converters had the buldge of the body toward the wrong side.

Wrong:
recom-wrong

Correct:
recom-correct

This affected the R-78B-2.0 (see https://www.recom-power.com/pdf/Innoline/R-78Bxx-2.0.pdf, page 5) and the R-78HB-0.5 (see https://www.recom-power.com/pdf/Innoline/R-78HBxx-0.5_L.pdf, page 5).

The changes were quite simple: moving everything except the pins downwards for 4.5mm.

The 3D models also need fixing, for this I created another pull request: KiCad/kicad-packages3D#327


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

the back while it should have been to the front.
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2018

CLA assistant check
All committers have signed the CLA.

@Shackmeister
Copy link
Collaborator

Thanks for the fix! :)

@Shackmeister Shackmeister merged commit 28d50c0 into KiCad:master Jun 24, 2018
@Shackmeister
Copy link
Collaborator

Hi @rschaeuble these footprints were actually generated via scripts like the 3D models. Could you please make a PR for the script with your changes? This way the bug won't come back if somebody re run the entire series from the script https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Recom_DCDC/Recom_SIP.py

@rschaeuble
Copy link
Contributor Author

rschaeuble commented Jun 25, 2018 via email

@rschaeuble
Copy link
Contributor Author

I have created a pull request for the generator script: pointhi/kicad-footprint-generator#141

While fixing the generator, I found a few other small errors in the footprints (wrong package widths, slightly wrong offset of pin 1 etc.). Once the generator has been accepted by its author, I will create new merge request for the footprints files in this repo. I will then also make the corresponding fixes to the 3D models.

@pointhi
Copy link
Collaborator

pointhi commented Jul 1, 2018

Please be careful about the recom regulators. They have both versions to my knowledge (bulge in front/back)

For example: https://www.recom-power.com/pdf/Innoline/R-78Exx-1.0.pdf

The question is now: does the Letter (B, HB, E,...) specify where the bulge is? I don't know.

@rschaeuble
Copy link
Contributor Author

It's not only the bulge There's also the issue that some datasheets specify the horizontal offset of pin 1, while others specify pin 3's offset, so pin 1 has to be calculated.

I've double and tripple checked all values when I made the changes in my pull request to the generator. I opened all footprints in KiCad, measured all relevant distances and compared them to the datasheets.

@evanshultz
Copy link
Collaborator

@rschaeuble
We typically merge footprints before the script, so that the output is checked and verified to be OK. Once footprints are merged then the script is merged. This has worked well for us so if you don't object would you please do footprints first?

@rschaeuble
Copy link
Contributor Author

@evanshultz: no objections at all. Here's the PR: #721

@myfreescalewebpage myfreescalewebpage added the Bug Fix footprint existing in the library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants