Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG : Mass Matrix Interpolation Overridden (ROM) #22

Closed
KikeM opened this issue May 30, 2021 · 0 comments · Fixed by KikeM/msc-thesis#40
Closed

BUG : Mass Matrix Interpolation Overridden (ROM) #22

KikeM opened this issue May 30, 2021 · 0 comments · Fixed by KikeM/msc-thesis#40
Assignees
@KikeM
Labels
bug Something isn't working

Comments

@KikeM
Copy link
Owner

KikeM commented May 30, 2021

I closed KikeM/msc-thesis#19 in PR-#34 because I thought I had correctly implemented the MDEIM for the mass matrix too. There was a bug in the code, the ROM interpolation was being computed and then overwritten by the FOM assembly and projection.

def assemble_mass(self, mu, t):
        
       if self.mdeim_Mh:            
            MN = self.mdeim_Mh.interpolate(mu=mu, t=t, which=self.mdeim_Mh.ROM)        
        
        # Assemble FOM operator        
        Mh = self.fom.assemble_mass(mu, t)        
        MN = self.to_rom_bilinear(Mh)
        
        return MN
@KikeM KikeM changed the title BUG : Incorrect mass matrix interpolation (ROM) BUG : Mass Matrix Interpolation Overridden (ROM) May 30, 2021
KikeM referenced this issue in KikeM/msc-thesis May 30, 2021
@KikeM
BUG: Mass matrix interpolation was being overridden by FOM projection
5a1c79a 
Fixes https://github.com/KikeM/msc-thesis/issues/38
KikeM referenced this issue in KikeM/msc-thesis May 30, 2021
@KikeM
BUG, CLN: Fix MDEIM bugs and reorganize folder structure
ea3f6ab 
  - BUG, ENH: Set boundary conditions in local assembly too
  - BUG: Mass matrix interpolation was being overridden by FOM projection
  - CLN: Generalized ROM projection for FOM operators
  - CLN: Move mass matrix assembly to OneDimensionalSolver

Fixes https://github.com/KikeM/msc-thesis/issues/38
Fixes https://github.com/KikeM/msc-thesis/issues/39
KikeM referenced this issue in KikeM/msc-thesis May 30, 2021
@KikeM
Merge pull request #40 from KikeM/cleaning/folder_structure
40de3f4 
Clean folder structure and fix MDEIM bugs.

- Set boundary values in the local assembly procedure too.
Thanks to this now the (M)DEIM online evaluation is correct, since the boundary values are correctly set.
- Move mass matrix assembly to OneDimensionalSolver.
- Parametrised MDEIM tests for stiffness and mass matrix.

Fixes #38 #39
KikeM referenced this issue Jun 14, 2021
@KikeM
BUG, CLN: Fix MDEIM bugs and reorganize folder structure
334a66f 
  - BUG, ENH: Set boundary conditions in local assembly too
  - BUG: Mass matrix interpolation was being overridden by FOM projection
  - CLN: Generalized ROM projection for FOM operators
  - CLN: Move mass matrix assembly to OneDimensionalSolver

Fixes https://github.com/KikeM/msc-thesis/issues/38
Fixes https://github.com/KikeM/msc-thesis/issues/39
@KikeM KikeM self-assigned this Aug 8, 2021
@KikeM KikeM transferred this issue from KikeM/msc-thesis Aug 8, 2021
@KikeM KikeM mentioned this issue Aug 8, 2021
Closed
@KikeM KikeM added the bug Something isn't working label Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KikeM KikeM

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG, CLN: MDEIM Bugs and Folder Structure KikeM/msc-thesis
1 participant
@KikeM