Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffix #1

Merged
merged 584 commits into from
Mar 7, 2019
Merged

ffix #1

merged 584 commits into from
Mar 7, 2019

Conversation

kiku-jw
Copy link
Owner

@kiku-jw kiku-jw commented Mar 7, 2019

See JENKINS-XXXXX.

Proposed changelog entries

  • Entry 1: Issue, Human-readable Text
  • ...

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

batmat and others added 30 commits January 4, 2019 22:25
After several tests of 3bfe97e I found that library does not support:
- proper using characters stored as \uXXXX so then translated files have values without \u
- keys with spaces such as `jenkins\ title` is not supported

So then I decided to revert last commit and add a little improvement but still there are problems with
- values which ends with `\` so value is provided as multiline
- lines with more than single `=` character that are already translated
Given this field is present in maven-hpi-plugin, update-center, etc.
I think it does not hurt to keep the 'Minimum-Java-Version' name across
various usages to help make it clear.
This way at least we know the backend methods should not be broken without
noticing.
…roblem was concealed by the original code not checking the command exit code.
jsoref and others added 29 commits February 20, 2019 18:59
Update to jenkins-test-harness:2.47
help: clean up LogRecorder.logger
* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .

Signed-off-by: Mit Naria <mit4dev@gmail.com>

* [FIX JENKINS-43218] Fix Fingerprint.toString()

1. Fix Fingerprint.toString() method when
   variable usages = null .

* [JENKINS-43218] - Retrigger the build after the Java 11 fixes on ci.jenkins.io
[JENKINS-56200] LogRecorder: support turning off a log recorder
* [JENKINS-56167] Replace Trilead-ssh2 PEMParser class by Mina SSHD SecurityUtils.loadKeyPairIdentity implementation

* Update PrivateKeyProviderTest.java

* Update cli/src/test/java/hudson/cli/PrivateKeyProviderTest.java

Co-Authored-By: kuisathaverat <kuisathaverat@users.noreply.github.com>

* Update PrivateKeyProviderTest.java

* Update PrivateKeyProvider.java

* Update PrivateKeyProviderTest.java

* Update PrivateKeyProvider.java
- avoid git-archeology to find when the interface was added
* spelling: dependent

Writers following British writing convention often confuse dependent and dependant. Those following US writing convention have an easier time with these words because Americans do not use dependant.

A dependant is a person who is dependent on someone else. (For example, a child is dependent on its parents. Therefore, a child is a dependant of its parents.)

Jenkins does not deal with people, thus the UK rule which is confusing does not apply.

* Add deprecated shims
…_LOG

Correct the Logger name for Legacy API Token monitor
* Add message to the build log when a build is running as SYSTEM

* Match previous log message
[JENKINS-42443] Fix spinner interaction with tabbar.less
Make use of covariant return types to return a String rather than an
Object.
return a String from StringParameterValue.getValue()
@kiku-jw kiku-jw merged commit 4394994 into kiku-jw:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.