Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Theming/colors #6

Open
JohnSandel opened this issue Feb 13, 2016 · 11 comments
Open

Feature request: Theming/colors #6

JohnSandel opened this issue Feb 13, 2016 · 11 comments

Comments

@JohnSandel
Copy link

FromScratch is a lovely piece of work. Thank you!

I'd find it more useful if text & background colors were user-definable. As is, I find the text harder to use than, say, black-on-white.

@adiultra
Copy link

Yep I do like the solarised light syntax theme rather than solarised dark. Also, It would be great to have custom font, because I am a real fan of Architects Daughter Font, for note taking.

@JohnSandel pls change the issue title to themeing ;p

@Kilian Kilian changed the title Feature request: color picker Feature request: Theming/colors Feb 15, 2016
@Kilian
Copy link
Owner

Kilian commented Feb 15, 2016

Would a settings/theming file in ~/.fromscratch suffice? a theme.json with this style?

{
  "background":"#000",
  "color": "#fff"
}

@adiultra
Copy link

@Kilian Yep It would definetly, But gui would be great for non programmers. 👍

@Kilian
Copy link
Owner

Kilian commented Feb 15, 2016

FromScratch currently has no management gui or settings, and I'd like to keep it that way.

@adiultra
Copy link

😢 😿

@spike1234
Copy link

+1

@Kilian
Copy link
Owner

Kilian commented Feb 26, 2016

I'm going to wait until electron updates to Chrome 48 or 49 so I can try and use css variables. Due to the theme now using SCSS to programmaticly define the highlight and focus colors based off the default colors, this is harder to do on runtime.

@altern8tif
Copy link

Is this still on the cards?

@Kilian
Copy link
Owner

Kilian commented Dec 29, 2016

Yes, but it turned out to be a bit more difficult than just setting the foreground and background :) I need a bunch of color functions to generate all the permutations (selection, found items, current line highlight) and that is currently done in SCSS. I could switch to CSS4 color functions and use PostCSS, but I would need to ship the parser and build something to parse a users css file with Fromscratch if end users should be able to theme. It's a difficult problem if you want to keep the automation for the styling that I have.

Another option is hue-rotate, which is very limited and basically only allows you to change the blue-ish tint to a different coloured tint, leaving the saturation and lightness the same (so you could have a dark theme in red, or green, or purple or whatever, but they would still be dark).

I'm holding out for a better option, or css4 color function support.

@otheroom otheroom mentioned this issue Dec 29, 2016
@Kilian
Copy link
Owner

Kilian commented May 15, 2017

It's a little work-in-progress, but I came up with a nice way to get a light theme:
selection_003

This allows me to re-use my theme setup, as it's essentially a color-corrected inversion :)

@spike1234
Copy link

very nice! I like it better than the standard colors! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants