Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is the Python3 status now? #251

Closed
laixintao opened this issue Feb 26, 2018 · 2 comments
Closed

How is the Python3 status now? #251

laixintao opened this issue Feb 26, 2018 · 2 comments

Comments

@laixintao
Copy link
Contributor

Hi, @KimiNewt , thanks for your work!

I work on Python3. I have forked your repo and wanted to merge python3 branch into master. but looks like there are few conflicts here: https://github.com/laixintao/pyshark/pull/1/files

Should I use Python3 branch or master?

@KimiNewt
Copy link
Owner

The normal master can and does run on python3 (I use python3 myself).

The branch simply makes the code simpler and drops support for python2. The reason I didn't merge it is that sadly, the majority of the users still use python2. When python2 usage drops further I will merge it. Thank you for the update of the branch, I can use it when I do finally merge it.

@laixintao
Copy link
Contributor Author

laixintao commented Feb 28, 2018

Hi, thanks!

I want to do more works on python3.5+(like fix this #250), and use it via pip install, so is that ok for you if I maintain a fork of python3 and upload that fork to pypi (https://pypi.org/project/py3shark/) ?

I kept author and license of course.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants