Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in adv360_left_defconfig? #427

Closed
khoek opened this issue Apr 5, 2024 · 2 comments
Closed

Possible typo in adv360_left_defconfig? #427

khoek opened this issue Apr 5, 2024 · 2 comments

Comments

@khoek
Copy link
Contributor

khoek commented Apr 5, 2024

I can't seem to find the config var CONFIG_ZMK_HID_KEYBOARD_EXTENDED_REPORT referenced in adv360_left_defconfig in the main ZMK repo, but I can find the very similar CONFIG_ZMK_HID_KEYBOARD_NKRO_EXTENDED_REPORT (noticed while discovering zmkfirmware/zmk#2253 actually). Is this a typo/old name from when the option was being developed?

Confusingly, this other name seemed to me to work just as well as the documented one, but I might have been too hasty in my testing. Perhaps this is all fine and there is some sort of compatibility/alias that I've missed which explains this?

@khoek
Copy link
Contributor Author

khoek commented Apr 5, 2024

Ah! I see it's in the custom fork. No worries. Sorry for the noise.

@khoek khoek closed this as completed Apr 5, 2024
@ReFil
Copy link
Collaborator

ReFil commented Apr 5, 2024

This feature was developed and implemented in the custom repo first, then upstreamed later. During the upstreaming process the zmk maintainers wanted the name of the kconfig option changed to better describe the option. As a result we now have an additional kconfig option in the custom fork to assign it properly for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants