-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧Refactor unit test assertions #301
Merged
CalvinWilkinson
merged 10 commits into
KinsonDigital:preview
from
thestbar:feature/106-refactor-unit-test-assertions
Oct 28, 2023
Merged
🚧Refactor unit test assertions #301
CalvinWilkinson
merged 10 commits into
KinsonDigital:preview
from
thestbar:feature/106-refactor-unit-test-assertions
Oct 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FluentAssertions
After discussion with @CalvinWilkinson the PR will be pushed for review even if sync status check fails, because the reason of the failure has to do with the CICD system. |
[run-sync] |
CalvinWilkinson
requested changes
Oct 23, 2023
Testing/CASLTests/Devices/Exceptions/AudioDeviceManagerNotInitializedExceptionTests.cs
Outdated
Show resolved
Hide resolved
Testing/CASLTests/Devices/Exceptions/AudioDeviceManagerNotInitializedExceptionTests.cs
Outdated
Show resolved
Hide resolved
Testing/CASLTests/Devices/Exceptions/InitializeDeviceExceptionTests.cs
Outdated
Show resolved
Hide resolved
Testing/CASLTests/Devices/Exceptions/InitializeDeviceExceptionTests.cs
Outdated
Show resolved
Hide resolved
[run-sync] |
CalvinWilkinson
added
good-first-issue
Good for newcomers
tech-debt
Code refactoring or cleanup / tech debt reduction
medium-priority
Medium Priority
🍺hacktoberfest-easy
Easy issue for new developers for hacktoberfest!! Hack away!!
labels
Oct 23, 2023
KinsonDigitalAdmin
requested changes
Oct 24, 2023
Testing/CASLTests/Devices/Exceptions/AudioDeviceManagerNotInitializedExceptionTests.cs
Outdated
Show resolved
Hide resolved
CalvinWilkinson
approved these changes
Oct 28, 2023
KinsonDigitalAdmin
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good-first-issue
Good for newcomers
🍺hacktoberfest-easy
Easy issue for new developers for hacktoberfest!! Hack away!!
medium-priority
Medium Priority
tech-debt
Code refactoring or cleanup / tech debt reduction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To allow this pull request to be merged, please make sure that the following items of this pull request are complete.
This pull request closes #106
✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.
Additional Info:
[run-sync]
command.