Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Refactor unit test assertions #301

Conversation

thestbar
Copy link
Contributor

@thestbar thestbar commented Oct 19, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #106

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@thestbar
Copy link
Contributor Author

After discussion with @CalvinWilkinson the PR will be pushed for review even if sync status check fails, because the reason of the failure has to do with the CICD system.

@thestbar thestbar marked this pull request as ready for review October 19, 2023 18:25
@CalvinWilkinson
Copy link
Member

[run-sync]

@CalvinWilkinson
Copy link
Member

[run-sync]

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.17 milestone Oct 23, 2023
@CalvinWilkinson CalvinWilkinson added good-first-issue Good for newcomers tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! labels Oct 23, 2023
@CalvinWilkinson CalvinWilkinson merged commit 2f47f65 into KinsonDigital:preview Oct 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚧Refactor unit test assertions
3 participants