Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #376: Denote readonly buckets & collections in the sidebar. #382

Merged
merged 6 commits into from
Feb 3, 2017

Conversation

n1k0
Copy link
Contributor

@n1k0 n1k0 commented Feb 2, 2017

refs #376, cc @Natim

@n1k0 n1k0 force-pushed the 376-denote-readonly-buckets branch from 83d1dcf to ce27f00 Compare February 2, 2017 23:00
@n1k0 n1k0 changed the title WiP #376: Denote readonly buckets & collections in the sidebar. Fix #376: Denote readonly buckets & collections in the sidebar. Feb 3, 2017
@n1k0
Copy link
Contributor Author

n1k0 commented Feb 3, 2017

r=? @Natim

Edit: ah wait not yet, it's missing the filters to hide read-only buckets.

@Natim
Copy link
Member

Natim commented Feb 3, 2017

Nice UX :D

@n1k0
Copy link
Contributor Author

n1k0 commented Feb 3, 2017

toggle

Final r=? @Natim

Copy link
Member

@Natim Natim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice \o/

@Natim
Copy link
Member

Natim commented Feb 3, 2017

Should we store the user prefs in the localstorage? Or hide the readonly ones by default? Or have a settings to choose?

@n1k0
Copy link
Contributor Author

n1k0 commented Feb 3, 2017

Should we iterate?

@n1k0
Copy link
Contributor Author

n1k0 commented Feb 3, 2017

I'm planning to add the following features:

I'll be linking/creating dedicated issues for these. Landing.

@n1k0 n1k0 merged commit ca9e891 into master Feb 3, 2017
@n1k0 n1k0 deleted the 376-denote-readonly-buckets branch February 3, 2017 09:41
n1k0 added a commit that referenced this pull request Feb 16, 2017
New features

* Fix #377, #378: Allow dropping edited resource properties. (#379)
* Fix #365: Render a JSON diff for history entries. (#380)
* Fix #376: Denote readonly buckets & collections in the sidebar. (#382)
* Fix #384: Live-searchable/filterable sidebar entries. (#385)
* Hide auth method selector when a single one is configured.

Bugfixes

* Do not store passwords. Fixes #364 (#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants