Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot drop a record property #378

Closed
n1k0 opened this issue Jan 31, 2017 · 1 comment
Closed

Cannot drop a record property #378

n1k0 opened this issue Jan 31, 2017 · 1 comment
Labels

Comments

@n1k0
Copy link
Contributor

n1k0 commented Jan 31, 2017

Because we perform PATCH requests, the sent record payload is always merged with its server version, so the property value always remains.

We could merge form values into initial record object when sending the request.

As patching is only required for collection attributes, so we don't lose attributes not handled by the edit form, we should:

  1. Drop our use of the patch option for updating buckets, groups and records (so we always replace records);
  2. Update the update logic for collections to always preserve existing fields when they initially exist on the server.

Spawned from #377.

@n1k0
Copy link
Contributor Author

n1k0 commented Feb 2, 2017

Fixed by #379.

@n1k0 n1k0 closed this as completed Feb 2, 2017
n1k0 added a commit that referenced this issue Feb 16, 2017
New features

* Fix #377, #378: Allow dropping edited resource properties. (#379)
* Fix #365: Render a JSON diff for history entries. (#380)
* Fix #376: Denote readonly buckets & collections in the sidebar. (#382)
* Fix #384: Live-searchable/filterable sidebar entries. (#385)
* Hide auth method selector when a single one is configured.

Bugfixes

* Do not store passwords. Fixes #364 (#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant