Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not store password in localStorage #364

Closed
leplatrem opened this issue Dec 19, 2016 · 7 comments
Closed

Do not store password in localStorage #364

leplatrem opened this issue Dec 19, 2016 · 7 comments
Labels
bug

Comments

@leplatrem
Copy link
Contributor

Maybe sessionStorage instead?
@n1k0
Copy link
Contributor

n1k0 commented Dec 19, 2016

why?

@Natim
Copy link
Member

Natim commented Dec 19, 2016

It is a bit dangerous to have some critical passwords unencrypted on the browser.

@n1k0
Copy link
Contributor

n1k0 commented Dec 19, 2016

Is it just for passwords or tokens as well?

@Natim
Copy link
Member

Natim commented Dec 19, 2016

I wish it was the case at least for LDAP passwords. Maybe we should have different policies for each auth plugin?

@n1k0
Copy link
Contributor

n1k0 commented Dec 27, 2016

We could also store the auth token generated after a succesful LDAP authentication instead of the password in clear? Or would that be still too sensitive?

@Natim
Copy link
Member

Natim commented Dec 28, 2016 •
edited
Loading

We don't have such thing (auth token) with the current LDAP setup. It is using BasicAuth so the username/password are sent as a base64 encrypted Authorization header.

If we move to auth0, we would be able to do that.

@Natim Natim added the bug label Feb 14, 2017
@Natim
Copy link
Member

Natim commented Feb 14, 2017

This is really important.

Natim pushed a commit that referenced this issue Feb 14, 2017
Do not store passwords. Fixes #364
192eb82
Natim pushed a commit that referenced this issue Feb 14, 2017
Do not store passwords. Fixes #364
26ec2d9
@Natim Natim mentioned this issue Feb 14, 2017
Merged
@Natim Natim closed this as completed in 6c47236 Feb 16, 2017
n1k0 added a commit that referenced this issue Feb 16, 2017
@n1k0
Bump v1.9.0.
b376de1 
New features

* Fix #377, #378: Allow dropping edited resource properties. (#379)
* Fix #365: Render a JSON diff for history entries. (#380)
* Fix #376: Denote readonly buckets & collections in the sidebar. (#382)
* Fix #384: Live-searchable/filterable sidebar entries. (#385)
* Hide auth method selector when a single one is configured.

Bugfixes

* Do not store passwords. Fixes #364 (#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@n1k0 @Natim @leplatrem