Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter objects where a particular field is null #1215

Closed
leplatrem opened this issue May 5, 2017 · 5 comments · Fixed by #1258
Closed

Filter objects where a particular field is null #1215

leplatrem opened this issue May 5, 2017 · 5 comments · Fixed by #1258
Assignees
@glasserc
Labels
enhancement protocol

Comments

@leplatrem
Copy link
Contributor

/records?field.name=null ?
@leplatrem leplatrem changed the title Filter object where a particular field is null Filter objects where a particular field is null May 5, 2017
@leplatrem
Copy link
Contributor Author

Related #343 #344

@glasserc
Copy link
Contributor

glasserc commented May 5, 2017

Isn't that syntax ambiguous? It's the same to search for any object whose value is the string "null". I'd rather be more rigid about what our query syntax is for this case, maybe introducing a new syntax for JSON-y values like is_field.name=null or json_field.name=null.

@glasserc glasserc mentioned this issue May 15, 2017
Closed
@glasserc glasserc mentioned this issue Jun 5, 2017
Merged
2 tasks
@Natim
Copy link
Member

Natim commented Jun 5, 2017

https://kinto-ota.dev.mozaws.net/v1/buckets/build-hub/collections/releases/records?build.id=null

Returns an empty list, so I guess it is not sufficient.

@glasserc
Copy link
Contributor

glasserc commented Jun 6, 2017

Should field.name=null match records where the field is missing, or only where it is explicitly present and null? (I would vote for the second option)

@glasserc glasserc mentioned this issue Jun 6, 2017
Closed
@glasserc glasserc self-assigned this Jun 7, 2017
@glasserc glasserc mentioned this issue Jun 7, 2017
Merged
4 tasks
@glasserc
Copy link
Contributor

glasserc commented Jun 8, 2017

Fixed by #1252 and #1258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glasserc glasserc

Labels
enhancement protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow JSON filtering and clarify sort order glasserc/kinto
3 participants
@glasserc @Natim @leplatrem