Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete fixes for #34 and #35 #39

Closed
MrXANA91 opened this issue Mar 18, 2024 · 2 comments
Closed

Incomplete fixes for #34 and #35 #39

MrXANA91 opened this issue Mar 18, 2024 · 2 comments

Comments

@MrXANA91
Copy link
Contributor

MrXANA91 commented Mar 18, 2024

PR #37 and #38 don't seem to have solved the issues #34 and #35

  • TEMP_CELSIUS const is probably still in use somewhere else in the integration
  • Simply adding ClimateEntityFeature.TURN_OFF and ClimateEntityFeature.TURN_ON is not enough to clear the deprecation warning

Yeah sorry I messed up.
I will look into it later today to check what I've missed and make sure the changes I'll implement really solve the issues this time.

@MrXANA91
Copy link
Contributor Author

MrXANA91 commented Mar 18, 2024

@MrXANA91
Copy link
Contributor Author

From #40 (comment)

This has been tested on my HA instance :

  • effectively removes the warnings
  • no issues using the Climate's turn_off and turn_on services

@KiraPC KiraPC closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants