Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csprojes are not indexed properly [source.dot.net] #208

Open
hankovich opened this issue Feb 21, 2022 · 2 comments
Open

Csprojes are not indexed properly [source.dot.net] #208

hankovich opened this issue Feb 21, 2022 · 2 comments

Comments

@hankovich
Copy link

I've noticed significant differences between csprojes in source.dot.net and in the dotnet repositories.

Some examples:
https://source.dot.net/#Microsoft.AspNetCore.Authentication.JwtBearer/Microsoft.AspNetCore.Authentication.JwtBearer.csproj
https://source.dot.net/#System.Linq/System.Linq.csproj

All cspject still have netcoreapp2.1 as TFM.

@KirillOsenkov
Copy link
Owner

I think this is by design. The .csproj files are artificially cleaned up and generated to ensure the indexing process can run in isolation from the actual build. @alexperovich can confirm, he wrote source.dot.net.

@alexperovich
Copy link
Contributor

Yes, this is by design. The projects and build system in all the dotnet repos are different enough and don't always have synchronized versions of dependencies that the indexer can't load all of them in the same process. I generate csprojs based on the csc commands found in the binlog to ensure that the compiler gets all the proper inputs for the indexing process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants