Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Inconsistent display of RA vs. non-RA retirements on KlimaData #2192

Open
0xAurelius opened this issue Jan 30, 2024 · 0 comments
Labels
bug Something isn't working data Requires input or change to the data klima data

Comments

@0xAurelius
Copy link
Contributor

Describe the bug
Some charts show non-RA retirements, while tables only include RA retirements on the Retirement Trends "By Token" page

Instead non-RA retirements should be included, and properly labeled if need be to clarify that for instance we cannot tie a retirement to a specific pool if it was not made via the RA

Reported by Drew in Discord: https://discord.com/channels/841390338324824096/964696746397679727/1201137163992039424

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://data.klimadao.finance/retirement-trends?tab=byToken
  2. Observe discrepancy between charts and tables

Expected behavior
KlimaData should consistently display retiremnets whether they are made using the RA or not

Screenshots
image

Additional context
There are legitimate differences in data availability for RA and non-RA retirements, so just need to treat that carefully

@0xAurelius 0xAurelius added the data Requires input or change to the data label Jan 30, 2024
@jabby09 jabby09 changed the title Inconsistent display of RA vs. non-RA retirements on KlimaData [dashboard] Inconsistent display of RA vs. non-RA retirements on KlimaData Jan 30, 2024
@jabby09 jabby09 added the bug Something isn't working label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Requires input or change to the data klima data
Projects
Status: No status
Development

No branches or pull requests

2 participants