Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name clash with multipart package. #16

Closed
tomchristie opened this issue Oct 11, 2018 · 3 comments
Closed

Name clash with multipart package. #16

tomchristie opened this issue Oct 11, 2018 · 3 comments

Comments

@tomchristie
Copy link
Collaborator

I don't especially mind that both multipart and python-multipart exist on PyPI, but it's a bit awkward that they both also install as multipart.

I've already managed to bump my head on this, and couldn't understand why the signature for multipart.MultipartParser wasn't as expected having had both packages installed at some point.

Although I much prefer the plain multipart name I wonder if it's worth considering something like multipartparser?

Alternatively we don't worry about it for now, and consider something later if it's an issue. Not sure.

@tiangolo
Copy link
Sponsor Contributor

I would like to second this. It's quite hard to detect when it happens, it took 3 of us for a whole day (or more) to finally discover we had both packages installed. I was about to call a server exorcist 😂

Of course, it was a bug in our code to have both installed, but the fact that sometimes one is used and some times the other for the same multipart makes it especially difficult to debug.

Would you consider changing the import name as @tomchristie suggests? 🙏

@Kludex
Copy link
Owner

Kludex commented Feb 10, 2024

I'm not fixing this.

My intention is to maintain this package till we merge the code to Starlette.

@Kludex Kludex closed this as completed Feb 10, 2024
@Kludex Kludex closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
@tomchristie
Copy link
Collaborator Author

@Kludex Appreciate a concise & clear response. 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants