-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name clash with multipart
package.
#16
Comments
I would like to second this. It's quite hard to detect when it happens, it took 3 of us for a whole day (or more) to finally discover we had both packages installed. I was about to call a server exorcist 😂 Of course, it was a bug in our code to have both installed, but the fact that sometimes one is used and some times the other for the same Would you consider changing the import name as @tomchristie suggests? 🙏 |
I'm not fixing this. My intention is to maintain this package till we merge the code to Starlette. |
@Kludex Appreciate a concise & clear response. 🌟 |
I don't especially mind that both
multipart
andpython-multipart
exist on PyPI, but it's a bit awkward that they both also install asmultipart
.I've already managed to bump my head on this, and couldn't understand why the signature for
multipart.MultipartParser
wasn't as expected having had both packages installed at some point.Although I much prefer the plain
multipart
name I wonder if it's worth considering something likemultipartparser
?Alternatively we don't worry about it for now, and consider something later if it's an issue. Not sure.
The text was updated successfully, but these errors were encountered: